Skip to content

Conversation

dineshSajwan
Copy link
Contributor

Issue # (if applicable)

Closes #<785>.

Reason for this change

Adding bedrock agent core runtime and runtime endpoint

Description of changes

  • Added a new L2 construct for runtime in aws -bedrock-agentcore-alpha package.
  • Added a new L2 construct for runtime endpoint
  • Added test cases
  • Added documentation

Describe any new or updated permissions being added

The runtime creates a role with permission to ecr repo, cloudwatch , xray .

Description of how you validated changes

Unit tests, integration tests, manual tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Sep 29, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 29, 2025 22:32
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@dineshSajwan dineshSajwan changed the title feat(agentcore): add agentcore runtime L2 constructs feat(agentcore): add agentcore runtime L2 construct Sep 29, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 30, 2025 02:43

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@alvazjor alvazjor self-assigned this Sep 30, 2025
/**
* Agent runtime artifact configuration for Bedrock Agent Core Runtime
*/
export interface AgentRuntimeArtifactConfig {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we expecting this configuration to have more elements in the future? Do you know if there are plans for that? Seems like having this interface at the moment is not adding too much value, you could potentially return the URI directly in the bind method rather than this object (in CDK, we tend to favor flat composition over nested composition if we can)

Copy link
Contributor Author

@dineshSajwan dineshSajwan Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mirrors the cloudformation structure of agentruntimeartifact . IMHO, we should keep it as cloud formation structure because if the underlying service add any new field in this object then the flat structure of containeruri may cause breaking changes for the L2 construct.

* @param clientId Cognito App Client ID
* @param region Optional AWS region (defaults to stack region)
*/
public configureCognitoAuth(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the other methods below are exactly what I was expecting to see instead of https://github.com/aws/aws-cdk/pull/35623/files#r2398909386.
Simple and specific for each type of auth configuration. I would prefer to keep only this idea and drop the possibility for the user to set up manually the auth config with all the possible wrong combinations they could make if we let it fully configurable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

public readonly endpointName: string;
public readonly agentRuntimeArn: string;
public readonly status?: string;
public readonly targetVersion?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between this and the agentRuntimeVersion ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually have two of those liveVersion and targetVersion. I have added liveVersion with this new commit.

this.liveVersion = this.endpointResource.attrLiveVersion;
this.targetVersion = this.endpointResource.attrTargetVersion;

https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-resource-bedrockagentcore-runtimeendpoint.html

https://docs.aws.amazon.com/bedrock-agentcore/latest/devguide/agent-runtime-versioning.html

As per my understanding

Initial Creation :

  • You set agentRuntimeVersion: "1"
  • Both liveVersion and targetVersion will be "1"
  • Status: READY

During Update :

  • Update runtime version to "2"
  • liveVersion remains "1"
  • targetVersion becomes "2" (transitioning to this)
  • Status: UPDATING

After Update Completes :

  • Both liveVersion and targetVersion become "2"
  • Status: READY

@mergify mergify bot dismissed alvazjor’s stale review October 6, 2025 17:01

Pull request has been modified.

@dineshSajwan dineshSajwan marked this pull request as ready for review October 6, 2025 19:40
@dineshSajwan dineshSajwan requested a deployment to deployment-integ-test October 7, 2025 13:55 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants