fix(ec2-alpha): imports of SubnetReference and VPCReference from aws-cdk-lib/aws-ec2 #35655
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
When attempting to use @aws-cdk/aws-ec2-alpha I get the following import error:
I'm using pnpm as the package manager, and typescript is using
bundler
as themoduleResolution
. Following the typescript module resolution output fromtsc --traceResolution
it seems like./aws-ec2/lib/ec2.generated
is not exposed publicly in thepackage.json
, and it will not attempt to load the file directly since it is a module-import and not a local import.From what I can tell it was introduced by #35032
Description of changes
This PR changes the imports of
SubnetReference
andVPCReference
to use the publicly available symbols fromaws-cdk-lib/aws-ec2
instead of importing them directly from the file itself. The alternative would be to add./aws-ec2/lib/ec2.generated
toaws-cdk-lib
'spackage.json
exports
.Description of how you validated changes
Manual update of the relevant
.d.ts
-files in a project importing@aws-cdk/aws-ec2-alpha
will solve the issue.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license