Skip to content

Conversation

tbrand
Copy link
Contributor

@tbrand tbrand commented Oct 3, 2025

AgentCore's VPC Endpoint support announced on Sep 25, 2025 was announced. The service names bedrock-agentcore and bedrock-agentcore.gateway mentioned in this document have been added to InterfaceVpcEndpointAwsService.

Reason for this change

New VPC Endpoints exist now.

Description of changes

Add the missing constants.

Describe any new or updated permissions being added

None.

Description of how you validated changes

The following code works as expected.

// Deploy on us-east-1
import * as cdk from 'aws-cdk-lib';
import { Construct } from 'constructs';
import * as ec2 from 'aws-cdk-lib/aws-ec2';

export class VpcEndpointTestStack extends cdk.Stack {
  constructor(scope: Construct, id: string, props?: cdk.StackProps) {
    super(scope, id, props);

    const vpc = new ec2.Vpc(this, 'Vpc', {
      availabilityZones: [
        'us-east-1a',
        'us-east-1c',
        'us-east-1d',
      ],
    });

    // AgentCore
    new ec2.InterfaceVpcEndpoint(this, 'AgentCore', {
      vpc,
      service: ec2.InterfaceVpcEndpointAwsService.BEDROCK_AGENTCORE,
    });

    // AgentCore Gateway
    new ec2.InterfaceVpcEndpoint(this, 'AgentCoreGateway', {
      vpc,
      service: ec2.InterfaceVpcEndpointAwsService.BEDROCK_AGENTCORE_GATEWAY,
    });
  }
}

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Yes, and I am an AWS employee.

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 3, 2025 03:02
@github-actions github-actions bot added the p2 label Oct 3, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@tbrand
Copy link
Contributor Author

tbrand commented Oct 3, 2025

I created this in the same way as this PR, so my understanding is that testing and documentation support are not necessary in the same manner.

@badmintoncryer
Copy link
Contributor

badmintoncryer commented Oct 4, 2025

@tbrand Thank you for your contribution. Could you please add a comment Exemption Request to pass all CI processes?

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 4, 2025
@tbrand
Copy link
Contributor Author

tbrand commented Oct 4, 2025

Exemption Request

@badmintoncryer
Copy link
Contributor

@tbrand Could you please update PR title? The 'needs-maintainer-review' label will be attached after that.

@tbrand
Copy link
Contributor Author

tbrand commented Oct 4, 2025

Thanks @badmintoncryer. How should I update the title specifically?

@badmintoncryer
Copy link
Contributor

As long as it’s updated, it’s fine. I think it’s okay to make some changes and then revert to the current title afterward!

@tbrand tbrand changed the title feat(ec2): add BEDROCK_AGENTCORE and BEDROCK_AGENTCORE_GATEWAY to InterfaceVpcEndpointAwsService feat(ec2): added BEDROCK_AGENTCORE and BEDROCK_AGENTCORE_GATEWAY to InterfaceVpcEndpointAwsService Oct 4, 2025
@tbrand tbrand changed the title feat(ec2): added BEDROCK_AGENTCORE and BEDROCK_AGENTCORE_GATEWAY to InterfaceVpcEndpointAwsService feat(ec2): add BEDROCK_AGENTCORE and BEDROCK_AGENTCORE_GATEWAY to InterfaceVpcEndpointAwsService Oct 4, 2025
@tbrand
Copy link
Contributor Author

tbrand commented Oct 4, 2025

Got it. I upated and reverted it.

@badmintoncryer
Copy link
Contributor

I’m not sure why, but it seems the build CI hasn’t been triggered.
It’s a simple change, so I believe a maintainer will approve it soon. Please wait a little while.

@alvazjor alvazjor added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Oct 7, 2025
@alvazjor alvazjor self-assigned this Oct 7, 2025
alvazjor
alvazjor previously approved these changes Oct 7, 2025
Copy link
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 7, 2025 08:44

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Oct 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 7, 2025
Copy link
Contributor

mergify bot commented Oct 7, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Oct 7, 2025
Copy link
Contributor

mergify bot commented Oct 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed alvazjor’s stale review October 7, 2025 09:18

Pull request has been modified.

alvazjor
alvazjor previously approved these changes Oct 7, 2025
@mergify mergify bot dismissed alvazjor’s stale review October 7, 2025 14:42

Pull request has been modified.

Copy link
Contributor

mergify bot commented Oct 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 7, 2025
Copy link
Contributor

mergify bot commented Oct 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6966c03 into aws:main Oct 7, 2025
28 checks passed
@mergify mergify bot removed the queued label Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2025
@tbrand tbrand deleted the feat/add-agentcore-vpc-endpoints branch October 8, 2025 00:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants