-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(ec2): add BEDROCK_AGENTCORE and BEDROCK_AGENTCORE_GATEWAY to InterfaceVpcEndpointAwsService #35667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…erfaceVpcEndpointAwsService
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
I created this in the same way as this PR, so my understanding is that testing and documentation support are not necessary in the same manner. |
@tbrand Thank you for your contribution. Could you please add a comment |
Exemption Request |
@tbrand Could you please update PR title? The 'needs-maintainer-review' label will be attached after that. |
Thanks @badmintoncryer. How should I update the title specifically? |
As long as it’s updated, it’s fine. I think it’s okay to make some changes and then revert to the current title afterward! |
Got it. I upated and reverted it. |
I’m not sure why, but it seems the build CI hasn’t been triggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
AgentCore's VPC Endpoint support announced on Sep 25, 2025 was announced. The service names bedrock-agentcore and bedrock-agentcore.gateway mentioned in this document have been added to InterfaceVpcEndpointAwsService.
Reason for this change
New VPC Endpoints exist now.
Description of changes
Add the missing constants.
Describe any new or updated permissions being added
None.
Description of how you validated changes
The following code works as expected.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Yes, and I am an AWS employee.