Skip to content

Conversation

@abidhasan-aws
Copy link
Contributor

@abidhasan-aws abidhasan-aws commented Oct 29, 2025

Reason for this change

The Auto Enum Updater action is failing because it attempts to create a new PR when there's already an existing PR with identical changes. The workflow should handle this scenario by closing the existing PR and creating a new one, but this functionality appears to be broken.

The issue is that when the workflow trying to find existing pr with --search $}{tittle}, it's not working.

Description of changes

Instead of listing the existing pr using --search, this change lists the pr using --base and --head.

Description of how you validated changes

The workflow has been tested in fork.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 29, 2025 11:38
@github-actions github-actions bot added the p2 label Oct 29, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 29, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@abidhasan-aws abidhasan-aws marked this pull request as ready for review October 29, 2025 11:41
@abidhasan-aws abidhasan-aws added the pr-linter/exempt-test The PR linter will not require test changes label Oct 29, 2025
@Abogical Abogical changed the title fix: auto enum updater ci(enum-auto-updater): auto enum updater Nov 4, 2025
@abidhasan-aws abidhasan-aws changed the title ci(enum-auto-updater): auto enum updater ci(Auto-Enum-Updater): replacing searching for pr with head and base instead of title Nov 4, 2025
@Abogical Abogical self-assigned this Nov 4, 2025
@abidhasan-aws
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2025

rebase

✅ Branch has been successfully rebased

@abidhasan-aws abidhasan-aws force-pushed the abidhsn/fix-auto-enum-updater-workflow branch from 339a5ab to 25a54d5 Compare November 4, 2025 11:14
@abidhasan-aws abidhasan-aws changed the title ci(Auto-Enum-Updater): replacing searching for pr with head and base instead of title ci(auto-enum-updater): replacing searching for pr with head and base instead of title Nov 4, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 4, 2025 12:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot force-pushed the abidhsn/fix-auto-enum-updater-workflow branch from 25a54d5 to 4749b79 Compare November 4, 2025 13:19
@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 67ef21f into main Nov 4, 2025
18 of 19 checks passed
@mergify mergify bot deleted the abidhsn/fix-auto-enum-updater-workflow branch November 4, 2025 13:57
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants