Skip to content

chore: clean up some more temporary directories in tests #36933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 2 commits into from
Feb 11, 2026
Merged

chore: clean up some more temporary directories in tests #36933

mergify merged 2 commits into from
Feb 11, 2026
+26 −24

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 10, 2026

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team February 10, 2026 14:12
@rix0rrr rix0rrr requested a review from a team as a code owner February 10, 2026 14:12
@aws-cdk-automation aws-cdk-automation requested a review from a team February 10, 2026 14:12
@github-actions github-actions bot added the p2 label Feb 10, 2026
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 10, 2026
@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Feb 10, 2026
mrgrain
mrgrain reviewed Feb 10, 2026
View reviewed changes
packages/aws-cdk-lib/core/test/fs/fs-copy.test.ts Outdated
import * as fs from 'fs';
import * as os from 'os';
import * as path from 'path';
import * as fs from 'fs-extra';
Copy link
Contributor

@mrgrain mrgrain Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion (non-blocking): fs-extra.removeSync can usually be replaced by the native fs.rm({ recursive: true, force: true })

@rix0rrr rix0rrr force-pushed the huijbers/cleanup-tempdirs branch from c16899d to 2a0aa36 Compare February 11, 2026 10:54
@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Feb 11, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2026 •
edited
Loading

Merge Queue Status

Rule: default-squash

  • ✅ Entered queue — 2026-02-11 11:55 UTC
  • ✅ Checks passed · in-place
  • ✅ Merged — 2026-02-11 12:25 UTC · at 22a09ad310e6749c6d35555359ce3751ad40819b

This pull request spent 29 minutes 57 seconds in the queue, including 29 minutes 48 seconds running CI.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c75371a into main Feb 11, 2026
17 of 18 checks passed
@mergify mergify bot deleted the huijbers/cleanup-tempdirs branch February 11, 2026 12:25
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rix0rrr @mrgrain