Skip to content

Conversation

@aemous
Copy link
Contributor

@aemous aemous commented Feb 4, 2025

Description of changes:

No changes apart from those in the reviewed PRs linked above are included in this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempting to run these for me is resulting in

(.venv312) ➜  performance git:(benchmarks) ✗ ./run-benchmarks
Traceback (most recent call last):
  File "/Users/shovlia/GitHub/aws-cli/scripts/performance/./run-benchmarks", line 38, in <module>
    harness.run_benchmarks(parser.parse_args())
  File "/Users/shovlia/GitHub/aws-cli/scripts/performance/benchmark_utils.py", line 410, in run_benchmarks
    measurements = self._run_isolated_benchmark(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/shovlia/GitHub/aws-cli/scripts/performance/benchmark_utils.py", line 351, in _run_isolated_benchmark
    with open(child_output_path, 'w') as out, open(child_err_path, 'w') as err:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'results/assets/output.txt'
Traceback (most recent call last):
  File "/Users/shovlia/GitHub/aws-cli/scripts/performance/./run-benchmarks", line 38, in <module>
    harness.run_benchmarks(parser.parse_args())
  File "/Users/shovlia/GitHub/aws-cli/scripts/performance/benchmark_utils.py", line 410, in run_benchmarks
    measurements = self._run_isolated_benchmark(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/shovlia/GitHub/aws-cli/scripts/performance/benchmark_utils.py", line 366, in _run_isolated_benchmark
    raise RuntimeError('Child process execution failed: output file not found.')
RuntimeError: Child process execution failed: output file not found.

@ashovlin ashovlin closed this Feb 10, 2025
@ashovlin ashovlin reopened this Feb 10, 2025
@ashovlin
Copy link
Member

It looks like you're missing the changes from #9264 somehow? I only see the S3 tests in benchmarks.json, don't see the file_literals support, etc.

@aemous
Copy link
Contributor Author

aemous commented Feb 10, 2025

It looks like you're missing the changes from #9264 somehow? I only see the S3 tests in benchmarks.json, don't see the file_literals support, etc.

Fixed in latest revision, thanks

* Move requirements changes to its own requirements file.
@aemous aemous merged commit dbfa393 into v2 Feb 14, 2025
80 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants