Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EBS Volume Provisioning Documentation for Spark on EKS #58

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update EBS Volume Provisioning Documentation for Spark on EKS #58

wants to merge 3 commits into from

Conversation

andormarkus
Copy link

@andormarkus andormarkus commented Oct 5, 2024 •
edited
Loading

Summary

This PR enhances the documentation for both EBS volume provisioning and instance store configuration in Spark on EKS environments. It provides more comprehensive information on different storage options and improves the overall clarity of the guides.

Changes

EBS Volume Provisioning

  • Added detailed explanations of two volume binding modes:
    • WaitForFirstConsumer
    • Immediate
  • Provided examples for creating storage classes for both modes
  • Updated Spark configuration examples for dynamic provisioning
  • Added warnings and informational notes to improve user understanding
  • Refined explanations for EBS volume attachment in various scenarios

Instance Store Configuration

  • Updated instance store configuration for EKS containerd compatibility
  • Removed Docker-specific commands from preBootstrapCommands
  • Adjusted permissions for /var/lib/kubelet
  • Simplified NVMe disk mounting process for EKS nodes

Motivation

These changes aim to provide users with a more complete and clear understanding of storage options in Spark on EKS. By explaining different EBS volume binding modes and updating the instance store configuration, users can make more informed decisions about their storage configuration and ensure compatibility with current EKS setups.

Testing

  • Documentation has been reviewed for accuracy
  • EBS volume provisioning examples have been tested in a Spark on EKS environment
  • Instance store configuration has been tested on an EKS cluster with containerd

Additional Notes

  • Users should be aware of the pros and cons of each EBS binding mode, especially when using the Immediate mode in multi-AZ environments.
  • The updated EBS documentation now aligns better with current best practices for EBS usage in Kubernetes environments.
  • The instance store configuration is now specific to EKS with containerd and may need adjustments if used with other container runtimes.

Reviewers: Please check for any unclear explanations or missing information.

@andormarkus-alcd
Update EBS volume provisioning docs for Spark on EKS
9ae8357 
 - Add information on WaitForFirstConsumer and Immediate binding modes
 - Provide examples for creating storage classes for both modes
 - Update Spark configuration examples for dynamic provisioning
 - Improve documentation with warnings and info notes for clarity
 - Refine explanations for EBS volume attachment in different scenarios
@andormarkus-alcd
Update instance store config for EKS containerd compatibility
d4c4646 
 - Remove Docker-specific commands from preBootstrapCommands
 - Adjust permissions for /var/lib/kubelet
 - Simplify NVMe disk mounting process for EKS nodes
@lmouhib lmouhib self-requested a review October 7, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melodyyangaws melodyyangaws melodyyangaws approved these changes

@lmouhib lmouhib Awaiting requested review from lmouhib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andormarkus @melodyyangaws @andormarkus-alcd