feat: perf-test for python #813
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
| @@ -0,0 +1,31 @@ | |||
| # ESDK Performance Testing - Python Dependencies | |||
There was a problem hiding this comment.
Do we need all these dependencies? A fair amount seem unused
There was a problem hiding this comment.
I was relying on linter and formatter to fix this, but apparently it didn't. Fixed it now.
|
|
||
| def _create_keyring(self): | ||
| """Create raw AES keyring""" | ||
| import secrets |
There was a problem hiding this comment.
These imports should go up top -- I think the MPL is intended to be required for this project so shouldn't need any special consideration
Comment on lines
+14
to
+19
| try: | ||
| from aws_encryption_sdk import EncryptionSDKClient, CommitmentPolicy | ||
| except ImportError as e: | ||
| print(f"Warning: Could not import ESDK modules: {e}") | ||
| print("Please install the AWS Encryption SDK: pip install aws-encryption-sdk") | ||
| sys.exit(1) |
There was a problem hiding this comment.
I think you can just import this?
Suggested change
| try: | |
| from aws_encryption_sdk import EncryptionSDKClient, CommitmentPolicy | |
| except ImportError as e: | |
| print(f"Warning: Could not import ESDK modules: {e}") | |
| print("Please install the AWS Encryption SDK: pip install aws-encryption-sdk") | |
| sys.exit(1) | |
| from aws_encryption_sdk import EncryptionSDKClient, CommitmentPolicy |
| "peak_memory_mb": 0.0, | ||
| "avg_memory_mb": 0.0, | ||
| "cumulative_allocations_mb": 0.0, | ||
| "memory_efficiency_ratio": 0.0, |
There was a problem hiding this comment.
Is there a README or similar that explains the results JSON? Some fields are obvious but things like this could use an explanation
Co-authored-by: Lucas McDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds a performance tests suite for python. The code was generated by agentic AI and was refactored by author.
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.