Skip to content

Add support for otfMetadata in Kinesis firehose response metadata for Iceberg routing #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2025
+62 −31
Merged

Add support for otfMetadata in Kinesis firehose response metadata for Iceberg routing #595

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2475752
Add support for otfMetadata in Kinesis firehose response metadata for…
Smelton01 Sep 2, 2025
5ec6ac4
Update tests
Smelton01 Sep 2, 2025
6d3b3e2
Use specific type for otf operations
Smelton01 Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion events/firehose.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ const (
KinesisFirehoseTransformedStateProcessingFailed = "ProcessingFailed"
)

// Constants used for otf operation for the record
const (
KinesisFirehoseOTFOperationInsert = "insert"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected type KinesisFirehoseOTFOperation string, like is done elsewhere for similar enum-likes in other events

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmoffatt
Thank you for the feedback Updated

KinesisFirehoseOTFOperationUpdate = "update"
KinesisFirehoseOTFOperationDelete = "delete"
)

type KinesisFirehoseResponse struct {
Records []KinesisFirehoseResponseRecord `json:"records"`
}
Expand All @@ -37,7 +44,14 @@ type KinesisFirehoseResponseRecord struct {
}

type KinesisFirehoseResponseRecordMetadata struct {
PartitionKeys map[string]string `json:"partitionKeys"`
PartitionKeys map[string]string `json:"partitionKeys"`
OTFMetadata KinesisFirehoseResponseRecordOTFMetadata `json:"otfMetadata"`
}

type KinesisFirehoseResponseRecordOTFMetadata struct {
DestinationTableName string `json:"destinationTableName"`
DestinationDatabaseName string `json:"destinationDatabaseName"`
Operation string `json:"operation"` // The Operation field must have one of the following values – insert, update, or delete.
}

type KinesisFirehoseRecordMetadata struct {
Expand Down
75 changes: 45 additions & 30 deletions events/testdata/kinesis-firehose-response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,46 @@
{
"records": [
{
"data": "SGVsbG8gV29ybGQ=",
"recordId": "record1",
"result": "TRANSFORMED_STATE_OK",
"metadata": {
"partitionKeys": {}
}
},
{
"data": "SGVsbG8gV29ybGQ=",
"recordId": "record2",
"result": "TRANSFORMED_STATE_DROPPED",
"metadata": {
"partitionKeys": {}
}
},
{
"data": "SGVsbG8gV29ybGQ=",
"recordId": "record3",
"result": "TransformedStateOk",
"metadata": {
"partitionKeys": {
"iamKey1": "iamValue1",
"iamKey2": "iamValue2"
}
}
}
]
}
"records": [
{
"data": "SGVsbG8gV29ybGQ=",
"recordId": "record1",
"result": "TRANSFORMED_STATE_OK",
"metadata": {
"partitionKeys": {},
"otfMetadata": {
"destinationTableName": "",
"destinationDatabaseName": "",
"operation": ""
}
}
},
{
"data": "SGVsbG8gV29ybGQ=",
"recordId": "record2",
"result": "TRANSFORMED_STATE_DROPPED",
"metadata": {
"partitionKeys": {},
"otfMetadata": {
"destinationTableName": "",
"destinationDatabaseName": "",
"operation": ""
}
}
},
{
"data": "SGVsbG8gV29ybGQ=",
"recordId": "record3",
"result": "TransformedStateOk",
"metadata": {
"partitionKeys": {
"iamKey1": "iamValue1",
"iamKey2": "iamValue2"
},
"otfMetadata": {
"destinationTableName": "table1",
"destinationDatabaseName": "database1",
"operation": "update"
}
}
}
]
}