Avoid appending empty path to artifact directory.#644
Merged
Conversation
3 tasks
Contributor
|
Thanks for the PR! 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
- Coverage 95.80% 92.89% -2.91%
==========================================
Files 61 67 +6
Lines 8143 9717 +1574
Branches 0 9717 +9717
==========================================
+ Hits 7801 9027 +1226
- Misses 342 402 +60
- Partials 0 288 +288 ☔ View full report in Codecov by Sentry. |
justsmth
approved these changes
Dec 30, 2024
skmcgrail
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Related to #571 (comment)
The build script for aws-lc-sys appends a library search path to the final linker command line. On Windows environments when building with lld-link.exe, the inclusion of an empty directory at the end of this path can cause a build failure.
The problematic path looks like this:
/LIBPATH:C:\\\\a\\\\servo\\\\servo\\\\target\\release\\build\\aws-lc-sys-d847be10163c7448\\out\\build\\artifacts\\The presence of the
\\at the end of the path causes the subsequent character to be treated as an escaped character, leading to a failure to parse the linker argument that follows this.Description of changes:
Since the final component of the path is always empty, we can remove it without any behaviour change.
Testing:
Verified this change by building Servo on Windows with my branch of aws-lc-sys. Before the change it failed to build; after the change it builds successfully.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.