Restore layer test tearDown image cleanup removed in #8666#8687
Merged
roger-zhangg merged 5 commits intodevelopfrom Feb 23, 2026
Merged
Restore layer test tearDown image cleanup removed in #8666#8687roger-zhangg merged 5 commits intodevelopfrom
roger-zhangg merged 5 commits intodevelopfrom
Conversation
Re-add the samcli/lambda-* Docker image cleanup in tearDown for TestLayerVersionBase and TestLayerVersionThatDoNotCreateCache. This was removed in PR #8666 to avoid cross-test interference in parallel runs, but these test classes are already serialized via xdist_group markers. Without the cleanup, stale cached images cause layer version tests to use outdated layers.
vicheey
previously approved these changes
Feb 23, 2026
Member
Author
|
there was dep issue: psf/requests#7222 |
valerena
reviewed
Feb 23, 2026
valerena
approved these changes
Feb 23, 2026
vicheey
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-add the samcli/lambda-* Docker image cleanup in tearDown for TestLayerVersionBase and TestLayerVersionThatDoNotCreateCache.
This was removed in PR #8666 to avoid cross-test interference in parallel runs, but these test classes are already serialized via xdist_group markers. Without the cleanup, stale cached images cause layer version tests to use outdated layers.
Changes:
_cleanup_samcli_imagesstatic method toTestLayerVersionBasethat removes allsamcli/lambda-*imagestearDowninTestLayerVersionBaseto call the cleanup + clear layer cachetearDowninTestLayerVersionThatDoNotCreateCacheto clean up images