fix: update esbuild build-in-source tests to nodejs24.x and CI to Node 24#8691
Merged
roger-zhangg merged 1 commit intodevelopfrom Feb 25, 2026
Merged
fix: update esbuild build-in-source tests to nodejs24.x and CI to Node 24#8691roger-zhangg merged 1 commit intodevelopfrom
roger-zhangg merged 1 commit intodevelopfrom
Conversation
…e 24 nodejs18.x is EOL and npm registry returns 403 for esbuild on Node 18. Update CI setup-node to 24 and test runtime to nodejs24.x.
reedham-aws
approved these changes
Feb 25, 2026
vicheey
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodejs18.x is EOL and the npm registry returns 403 for esbuild when running on Node 18, causing
TestBuildCommand_BuildInSource_Esbuildtests to fail.Changes
setup-nodeinbuild.ymlfrom Node 22 to Node 24nodejs18.xtonodejs24.x