[do not merge] feat: support account id in imds / new profile configs #3067
+1,389
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
force-pushed
the
feat-imdsaccountid
branch
from
6bb19ab to
17dd424
Compare
lucix-aws
force-pushed
the
feat-imdsaccountid
branch
from
17dd424 to
49c542f
Compare
Madrigal
reviewed
Apr 18, 2025
| restoreEnv := awstesting.StashEnv() | ||
| defer awstesting.PopEnv(restoreEnv) | ||
|
|
||
| os.Setenv("AWS_EC2_METADATA_SERVICE_ENDPOINT", ec2MetadataURL) |
There was a problem hiding this comment.
nit: use t.Setenv instead
|
|
||
| func (c EnvConfig) getEC2InstanceProfileName() (string, bool, error) { | ||
| if len(c.EC2InstanceProfileName) == 0 { | ||
| return "", false, nil |
There was a problem hiding this comment.
It was discussed to err on this rather than leaving it empty. My main concern would be that someone would want to set this to something on their shell, like export AWS_EC2_INSTANCE_PROFILE_NAME=$(some_process_that_returns_a_value), and that something returns an empty string, then they would make a request to the base URL rather than to the profile they were trying to use
There was a problem hiding this comment.
This was addressed but not here -- it actually uses Lookupenv to check for explicit empty in the main load routine.
lucix-aws
changed the title
Madrigal
approved these changes
Apr 21, 2025
wty-Bryant
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: the new
-extendedmetadata endpoint is not yet available.*-extended/credentials endpoint for IMDS, with automatic fallback to the old oneAWS_EC2_INSTANCE_PROFILE_NAMEand friends