Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DynamoDbEnhancedClient DefaultDynamoDbAsyncTable::createTable()… #5847

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roamariei
Copy link
Contributor

@roamariei roamariei commented Jan 31, 2025

Fixed DynamoDbEnhancedClient DefaultDynamoDbAsyncTable::createTable() to create secondary indices that are defined on annotations of the POJO class, similar to DefaultDynamoDbTable::createTable().

Description

Current behavior: DynamoDbEnhancedAsyncClient#createTable() fails to generate secondary indexes that are defined on annotations of the POJO class.

Expected behavior: DynamoDbEnhancedAsyncClient#createTable() should generate secondary indexes that are defined on annotations of the POJO class, similar to DefaultDynamoDbTable::createTable().

Motivation and Context

#5400

Modifications

Followed the same approach as the synchronous flow in DefaultDynamoDbTable::createTable(). Refactored existing code to enable reuse across both classes.

Testing

The changes have already been tested in the synchronous flow, and additional unit tests have been added for the newly created utility class.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@roamariei roamariei requested a review from a team as a code owner January 31, 2025 11:31
@roamariei roamariei force-pushed the bugfix/async-client-fails-to-generate-secondary-indexes-from-annotations-pojo-class branch from 726a764 to a802297 Compare March 12, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant