Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing test cases #5929

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Conversation

sugmanue
Copy link
Contributor

@sugmanue sugmanue commented Mar 5, 2025

Motivation and Context

A follow up to #5911 to add some other tests cases suggested in the comments.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sugmanue sugmanue requested a review from a team as a code owner March 5, 2025 17:54
@sugmanue sugmanue mentioned this pull request Mar 5, 2025
12 tasks
@sugmanue sugmanue enabled auto-merge March 5, 2025 18:01
Copy link
Contributor

@RanVaknin RanVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link

sonarqubecloud bot commented Mar 5, 2025

@sugmanue sugmanue added this pull request to the merge queue Mar 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2025
@sugmanue sugmanue added this pull request to the merge queue Mar 6, 2025
@sugmanue sugmanue mentioned this pull request Mar 6, 2025
12 tasks
Merged via the queue into master with commit 2233dd6 Mar 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants