Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special cases for Enum Recipe added #5934

Merged
merged 7 commits into from
Mar 6, 2025
Merged

Conversation

Fred1155
Copy link
Contributor

@Fred1155 Fred1155 commented Mar 5, 2025

Motivation and Context

Handled special cases for migration tool recipe for S3 Enums (S3Event, StorageClass)

Modifications

  1. Added a static map to handle special cases for three enums in StorageClass
  2. Added handling of v1 S3Event to v2 Event in s3 package
  3. Added "S3_" prefix for all v1 S3Event enums when transforming to v2

Testing

  1. Added test code in before and after integration test file

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner March 5, 2025 23:48
@Fred1155 Fred1155 enabled auto-merge March 6, 2025 18:52
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Fred1155 Fred1155 added this pull request to the merge queue Mar 6, 2025
Merged via the queue into master with commit 7b946c1 Mar 6, 2025
16 of 17 checks passed
@Fred1155 Fred1155 deleted the bole/create_S3_enum_recipes branch March 14, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants