Skip to content

added special case to handle bucketName #5971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -375,4 +375,9 @@ private void setBucketConfigs(S3Client s3, String bucket) {
.build())
.build());
}

private void setBucketNameTest(S3Client s3, String bucket) {
GetObjectRequest getObjectRequest = GetObjectRequest.builder().bucket(bucket).key("key").bucket(bucket)
.build();
}
}
Original file line number Diff line number Diff line change
@@ -35,6 +35,7 @@
import com.amazonaws.services.s3.model.DeleteBucketRequest;
import com.amazonaws.services.s3.model.GetBucketCrossOriginConfigurationRequest;
import com.amazonaws.services.s3.model.GetObjectMetadataRequest;
import com.amazonaws.services.s3.model.GetObjectRequest;
import com.amazonaws.services.s3.model.HeadBucketRequest;
import com.amazonaws.services.s3.model.HeadBucketResult;
import com.amazonaws.services.s3.model.InitiateMultipartUploadRequest;
@@ -235,4 +236,8 @@ private void setBucketConfigs(AmazonS3 s3, String bucket) {
s3.setBucketTaggingConfiguration(bucket, new BucketTaggingConfiguration());
s3.setBucketWebsiteConfiguration(bucket, new BucketWebsiteConfiguration());
}

private void setBucketNameTest(AmazonS3 s3, String bucket) {
GetObjectRequest getObjectRequest = new GetObjectRequest(bucket, "key").withBucketName(bucket);
}
}
Original file line number Diff line number Diff line change
@@ -102,6 +102,10 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation previousMetho
methodName = NamingUtils.removeSet(methodName);
}

if ("bucketName".equals(methodName)) {
methodName = "bucket";
}

if (isClientBuilderClass(methodType)) {
methodName = CLIENT_CONFIG_NAMING_MAPPING.getOrDefault(methodName, methodName);
}