Migration tool - Date to Instant #5986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred1155
reviewed
Mar 24, 2025
| } | ||
|
|
||
| boolean isDateParam = javaType.isAssignableFrom(DATE_PATTERN); | ||
| return SdkTypeUtils.isV2ModelBuilder(declaringType) && isDateParam; |
There was a problem hiding this comment.
Do we have special cases where Date objects should NOT be transformed?
There was a problem hiding this comment.
No Date in v2, will all be Instant afaik. At least for POJO setters
Fred1155
approved these changes
Mar 24, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
v1 takes
Dateargs, while v2 takesInstantargsModifications
Added new recipe
DateToInstantto appendtoInstant()toDateargsTesting
Added end to end tests