Added comments in migration tool for unsupported method #6018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joviegas
reviewed
Apr 9, 2025
| @@ -199,12 +199,12 @@ public void requestconstructor() { | |||
| .build()); | |||
|
|
|||
| //INCOMPATIBLE RESPONSE | |||
There was a problem hiding this comment.
If the newly added comment is single line can we use// Single-line comment for the new comment added
joviegas
reviewed
Apr 9, 2025
| @@ -199,12 +199,12 @@ public void requestconstructor() { | |||
| .build()); | |||
|
|
|||
| //INCOMPATIBLE RESPONSE | |||
| s3.getBucketAccelerateConfiguration(GetBucketAccelerateConfigurationRequest.builder().bucket(bucketName) | |||
There was a problem hiding this comment.
why does V1 style from /before/
s3.getBucketAccelerateConfiguration(new GetBucketAccelerateConfigurationRequest(bucketName));
gets converted to V2 when it says Transform is not supported ?
…aws-sdk-java-v2 into bole/s3Clients_not_supported_method
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some S3 method will not be supported in migration tool and will require manually migration. This change added comments before those method to address that. Once the dec guide is updated on how to manually migrate those method, the link to the dev guide will be added in future PR.
Modifications
Added method name check in S3NonStreamingRequestToV2.java recipe
Testing
Changed the test cases in integration test
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License