Skip to content

URI cache for DynamoDB account id based endpoint #6087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

L-Applin
Copy link
Contributor

@L-Applin L-Applin commented May 5, 2025

Add caching in front on URI constructors methods to minimize performance impact of creating URIs with account id based endpoints.

Motivation and Context

Potential performance degredation with such URIs.

Modifications

  • Added a SdkURI class which caches calls to the various URI constructors methods.
  • Added customization configuration to codegen to enable usage of SdkURI class in generated endpoint resolution code. Enabled this config only for DynamoDB.

Testing

  • Unit test
  • Performance tests and profiling
  • Canary testing in progress

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Copy link

sonarqubecloud bot commented May 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
76.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant