Skip to content

fix multi line xml tag, and add maven central validation #6400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+28 −3
Open

fix multi line xml tag, and add maven central validation #6400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions .github/workflows/new-module-verification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,23 +129,23 @@ jobs:
fi

# 2. Check if added to tests-coverage-reporting pom.xml
if ! grep -q "<dependency>.*$MODULE_NAME</dependency>" test/tests-coverage-reporting/pom.xml 2>/dev/null; then
if ! grep -q "<artifactId>$MODULE_NAME</artifactId>" test/tests-coverage-reporting/pom.xml 2>/dev/null; then
echo "::error::Module $MODULE_NAME is not added to tests-coverage-reporting pom.xml"
HAS_ERRORS=1
else
echo "✅ Module is added to tests-coverage-reporting"
fi

# 3. Check if added to aws-sdk-java pom.xml
if ! grep -q "<dependency>.*$MODULE_NAME</dependency>" aws-sdk-java/pom.xml 2>/dev/null; then
if ! grep -q "<artifactId>$MODULE_NAME</artifactId>" aws-sdk-java/pom.xml 2>/dev/null; then
echo "::error::Module $MODULE_NAME is not added to aws-sdk-java pom.xml"
HAS_ERRORS=1
else
echo "✅ Module is added to aws-sdk-java pom.xml"
fi

# 4. Check if added to architecture-tests pom.xml
if ! grep -q "<dependency>.*$MODULE_NAME</dependency>" test/architecture-tests/pom.xml 2>/dev/null; then
if ! grep -q "<artifactId>$MODULE_NAME</artifactId>" test/architecture-tests/pom.xml 2>/dev/null; then
echo "::error::Module $MODULE_NAME is not added to architecture-tests pom.xml"
HAS_ERRORS=1
else
Expand Down Expand Up @@ -176,6 +176,31 @@ jobs:
else
echo "✅ Package name mapping is added in .brazil.json"
fi

# 8. Maven Central validation - Check for required tags
echo "Verifying Maven Central requirements..."

if ! grep -q "<name>" "$POM_FILE" 2>/dev/null; then
echo "::error::Maven Central validation: <name> tag is missing in $POM_FILE"
HAS_ERRORS=1
else
echo "✅ Maven Central validation: <name> tag is present"
fi

if ! grep -q "<description>" "$POM_FILE" 2>/dev/null; then
echo "::error::Maven Central validation: <description> tag is missing in $POM_FILE"
HAS_ERRORS=1
else
echo "✅ Maven Central validation: <description> tag is present"
fi

if ! grep -q "<url>" "$POM_FILE" 2>/dev/null; then
echo "::error::Maven Central validation: <url> tag is missing in $POM_FILE"
HAS_ERRORS=1
else
echo "✅ Maven Central validation: <url> tag is present"
fi

echo "::endgroup::"
fi
done
Expand Down
Loading