test(client-s3): convert feature test to vitest #7214
Merged
+647
−1,053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
test/feature-s3
branch
2 times, most recently
from
e17cb4c to
6604426
Compare
kuhe
commented
Jul 21, 2025
| setupProxyServer.call(this); | ||
|
|
||
| this.service = this.s3 = new S3({ | ||
| httpOptions: { |
There was a problem hiding this comment.
httpOptions is not a config prop of S3 in v3, so this test accomplished nothing, I think.
| ContentLength: parseInt(contentLength), | ||
| }; | ||
| this.s3nochecksums = new this.S3({ | ||
| computeChecksums: false, |
There was a problem hiding this comment.
this flag doesn't exist in v3, so this test probably did nothing
2 tasks
trivikr
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converts s3 feature tests in cucumber to vitest