-
Notifications
You must be signed in to change notification settings - Fork 647
chore: move e2e tests from cucumber to vitest #7539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79c8ad9 to
e15aef3
Compare
kuhe
reviewed
Dec 3, 2025
kuhe
reviewed
Dec 3, 2025
kuhe
reviewed
Dec 3, 2025
kuhe
reviewed
Dec 3, 2025
clients/client-cloudformation/test/cloudformation-features.e2e.spec.ts
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Dec 3, 2025
clients/client-cloudformation/test/cloudformation-features.e2e.spec.ts
Outdated
Show resolved
Hide resolved
338fa1e to
49939c5
Compare
4439db1 to
9af67c6
Compare
trivikr
approved these changes
Dec 18, 2025
kuhe
requested changes
Dec 19, 2025
clients/client-cognito-identity/test/e2e/cognitoidentity-features.e2e.spec.ts
Outdated
Show resolved
Hide resolved
d4e90f2 to
519d5e1
Compare
kuhe
reviewed
Dec 22, 2025
| receiveResult = await client.receiveMessage({ | ||
| QueueUrl: queueUrl, | ||
| MessageAttributeNames: ["binary"], | ||
| }); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, use WaitTimeSeconds in the receiveMessage request instead of a custom waiter.
kuhe
approved these changes
Dec 22, 2025
519d5e1 to
3bfa7b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-6402
Description
Removes the dependency on cucumber and converts feature tests to e2e tests.
Testing
CI
Checklist
*.integ.spec.ts).@publictag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.