feat(middleware-flexible-checksums): use CRC64NVME JS implementation if CRT is not available #7595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
trivikr
force-pushed
the
trivikr/crc64-nvme-js
branch
from
0bbc9c7 to
25666af
Compare
kuhe
reviewed
Dec 22, 2025
kuhe
reviewed
Dec 22, 2025
packages/middleware-flexible-checksums/src/selectChecksumAlgorithmFunction.ts
Show resolved
Hide resolved
yarn build is throwing error in current setup
× Invalid package dependency graph:
╰─▶ Cyclic dependency detected:
@aws-sdk/crc64-nvme, @aws-sdk/middleware-flexible-checksums, @aws-sdk/crc64-nvme-crt
The cycle can be broken by removing any of these sets of dependencies:
{ @aws-sdk/middleware-flexible-checksums -> @aws-sdk/crc64-nvme }
{ @aws-sdk/crc64-nvme -> @aws-sdk/crc64-nvme-crt }
{ @aws-sdk/crc64-nvme-crt -> @aws-sdk/middleware-flexible-checksums }
trivikr
force-pushed
the
trivikr/crc64-nvme-js
branch
from
d03414e to
85fa1e9
Compare
kuhe
approved these changes
Dec 22, 2025
packages/middleware-flexible-checksums/src/middleware-flexible-checksums.crt.integ.spec.ts
Show resolved
Hide resolved
Member
Author
|
The CI failure was in unrelated test. It was retried, and succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-5866
Description
Ensures that JavaScript implementation is used for CRC64NVME computation if CRT is not available
Testing
CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.