Fix a bug in WorkflowTest.java #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WorkflowTest rule does not use the DataConverter that is specified in the Workflow annotation. Instead, it always uses the JsonDataConverter. This means that if you try to use your own DataConverter with the WorkflowTest rule, your tests will fail if the JsonDataConverter can't deserialize something that your custom DataConverter serialized. This change creates an overloaded constructor that will allow developers to construct the WorkflowTest rule with their custom DataConverter implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The WorkflowTest rule does not use the DataConverter that is specified in the Workflow annotation. Instead, it always uses the JsonDataConverter. This means that if you try to use your own DataConverter with the WorkflowTest rule, your tests will fail if the JsonDataConverter can't deserialize something that your custom DataConverter serialized.
How this change solves it
This change creates an overloaded constructor that will allow developers to construct the WorkflowTest rule with their custom DataConverter implementation.
Licensing
Amazon already owns the rights to this contribution due to a previously signed agreement.