Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Q Code Transform - Add 'unknown' type to BuildSystem and BuildCommand #798

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tincheng
Copy link
Contributor

Problem

When generating types from shared telemetry, IntelliJ automatically adds an additional "Unknown" value to enum types. VSCode does not.

Solution

  • Add "unknown" to codeTransformBuildSystem and codeTranformBuildCommand explicitly.
  • Make codeTransformBuildSystem and codeTranformBuildCommand optional in case other IDE wants to emit these metrics without build system and command.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tincheng tincheng requested a review from a team as a code owner July 26, 2024 19:52
@tincheng tincheng changed the title Metric Amazon Q Code Transform - Add 'unknown' type to BuildSystem and BuildCommand Jul 26, 2024
@@ -289,7 +289,8 @@
"gradlew.bat",
"gradlew",
"gradle",
"IDEBundledGradle"
"IDEBundledGradle",
"unknown"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both VS and JB autogenerate the unknown type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants