Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Q: Allow customers to configure the ability to run code and tests with /dev #5307

Merged
merged 111 commits into from
Jan 28, 2025

Conversation

neilk-aws
Copy link
Contributor

This feature enables customers to configure whether to run code and tests with /dev per project.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

On the first run of /dev for a project, if a devfile.yaml exists in the root of the project, the customer is prompted to know if they want to use the commands in the file to test the code we generate. The feature additionally allows customers to generate a devfile if one doesn't exist. Their choice is persisted and configurable in the Amazon Q settings.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

aws-toolkit-automation and others added 14 commits November 22, 2024 22:58
…ecution. (#5295)

#### Parameter Update for Testing:
- Updated function parameters to address testing issues introduced by changes made in PR #5077.
#### Enhanced Development Prompt:
- Modified GENERATE_DEV_FILE_PROMPT to support running install, build, and test commands independently.
#### Improved Build and Code File Upload Logic:
- Updated the logic to enable uploading build files alongside code files.
* feat: Allow including binary files when auto build is enabled

* attempt fixing test failures on windows

* fix windows tests
Improves the formatting and strings presented to customers when the allow /dev to run code and test commands automatically. Also includes minor variable name changes to improve internal consistency.
@neilk-aws neilk-aws requested review from a team as code owners January 28, 2025 20:15
Copy link

github-actions bot commented Jan 28, 2025

Qodana Community for JVM

8 new problems were found

Inspection name Severity Problems
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 7
Class member can have 'private' visibility ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@rli rli enabled auto-merge January 28, 2025 22:56
@rli rli disabled auto-merge January 28, 2025 23:43
@rli rli merged commit 0cd4bca into main Jan 28, 2025
5 of 25 checks passed
async { pattern.matches("$relative/") }
}
}
fun ignoreFile(file: VirtualFile, applyExtraBinaryFilesRules: Boolean = true): Boolean = ignoreFile(file.presentableUrl, applyExtraBinaryFilesRules)

Check notice

Code scanning / QDJVMC

Class member can have 'private' visibility Note

Function 'ignoreFile' could be private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants