-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon Q: Allow customers to configure the ability to run code and tests with /dev #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into feature/dev-execution
…ecution. (#5295) #### Parameter Update for Testing: - Updated function parameters to address testing issues introduced by changes made in PR #5077. #### Enhanced Development Prompt: - Modified GENERATE_DEV_FILE_PROMPT to support running install, build, and test commands independently. #### Improved Build and Code File Upload Logic: - Updated the logic to enable uploading build files alongside code files.
* feat: Allow including binary files when auto build is enabled * attempt fixing test failures on windows * fix windows tests
Improves the formatting and strings presented to customers when the allow /dev to run code and test commands automatically. Also includes minor variable name changes to improve internal consistency.
osdemah
approved these changes
Jan 28, 2025
Qodana Community for JVM8 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
async { pattern.matches("$relative/") } | ||
} | ||
} | ||
fun ignoreFile(file: VirtualFile, applyExtraBinaryFilesRules: Boolean = true): Boolean = ignoreFile(file.presentableUrl, applyExtraBinaryFilesRules) |
Check notice
Code scanning / QDJVMC
Class member can have 'private' visibility Note
Function 'ignoreFile' could be private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables customers to configure whether to run code and tests with /dev per project.
Types of changes
Description
On the first run of
/dev
for a project, if adevfile.yaml
exists in the root of the project, the customer is prompted to know if they want to use the commands in the file to test the code we generate. The feature additionally allows customers to generate a devfile if one doesn't exist. Their choice is persisted and configurable in the Amazon Q settings.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.