bug fix(amazonq): fix an issue where user action is accept but telemetry is reject #5319
+36
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shouldEditorCancelPopup variable should increment/decrement in-pair inside
dontClosePopupAndRun
logic and theCodeWhispererPopupIntelliSenseAcceptListener
logic, but there was some race condition that makesCodeWhispererPopupIntelliSenseAcceptListener
's setting false afterdontClosePopupAndRun
's setting true,so now making it a semaphore-like val to make sure it was updated properly.
The common scenario is as follows:
beforeItemSelected
is not triggered to make it to false, (so a part of this fix is to make thebeforeItemSelected
logic tolookupShown
logic and make it an int so it can be incremented twice so decrementing doesn't completely reset it.)Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.