Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cwsprClientAdapr stateless and obtain sdk client directly from AwsClientManager #5331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Feb 6, 2025

Description

There is no need to store a client as a state within this class, AwsClientManager already handle the connection change

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua changed the title cwsprClientAdaptor should use awsClientManager client directly cwsprClientAdaptor should be stateless and get client directly from AwsClientManager Feb 6, 2025
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review February 6, 2025 20:16
@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner February 6, 2025 20:16
@Will-ShaoHua Will-ShaoHua requested review from rli and andrewyuq February 6, 2025 20:16
@Will-ShaoHua Will-ShaoHua changed the title cwsprClientAdaptor should be stateless and get client directly from AwsClientManager make cwsprClientAdapr stateless and obtain sdk client directly from AwsClientManager Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant