feat(lambda): download serverless land patterns in IDE #6612

Vandita2020 · 2025-02-18T19:40:29Z

Problem

This pull request introduces the functionality to allow users to download the selected pattern from the Serverless Land QuickPick flow into a directory of their choice.

Solution

The key changes made are as follows:

The metadata.json file was updated to accommodate the addition of an asset_name field for each IaC and Runtime pair.
Consequently, the way the metadata is extracted in the metadataManager.ts file had to be modified to account for these changes in the metadata.json file.
To enable users to navigate back to the previous QuickPick options, a switch functionality was implemented in the wizard.ts file. This helps maintain the state of the current QuickPick and directs the user to the previous QuickPick.

Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
Your code changes must meet the guidelines in CONTRIBUTING.md.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions · 2025-02-18T19:40:43Z

This pull request modifies code in src/* but no tests were added/updated.
- Confirm whether tests should be added or ensure the PR description explains why tests are not required.

roger-zhangg

Questions in Wizard part, also please add test

packages/core/src/awsService/appBuilder/serverlessLand/wizard.ts

roger-zhangg · 2025-02-20T22:05:32Z

packages/core/src/awsService/appBuilder/serverlessLand/main.ts

+    }).run()
+}
+
+async function downloadPatternCode(config: CreateServerlessLandWizardForm): Promise<void> {


Seems you are providing a Official Serverless Land experience here, could you help to update the Download SL logic I have in walkthrough to use your logic here?

If this is going to be used in other places as well, I suggest bringing these function outside of main.py and into another file in this folder for readability.

roger-zhangg · 2025-02-20T22:06:55Z

packages/core/src/awsService/appBuilder/serverlessLand/wizard.ts

-            if (patterns.length === 0) {
-                throw new ToolkitError('No patterns found in metadata')
-            }
+            let step = 'pattern'


for line 40, IMO we should avoid public override async run(): when possible. Just put all the async prework out of the wizard. the override async run() has cause difficulties in testing as my experience.

The code has been simplified, and the logic that was previously executed within the public override async run() method has been moved to the public constructor. No longer need to override the run() function.

github-actions · 2025-02-20T23:12:58Z

This pull request modifies code in src/* but no tests were added/updated.
- Confirm whether tests should be added or ensure the PR description explains why tests are not required.
This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
- Note: beta or "experiment" features that have active users should announce fixes in the changelog.
- If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

vicheey · 2025-02-20T21:59:47Z

packages/core/src/awsService/appBuilder/serverlessLand/main.ts

-            credentials,
-            defaultRegion,
-        }).run()
+        const config = await launchProjectCreationWizard(extContext)
        if (!config) {
            createResult = 'Cancelled'


What is the the purpose behind setting value to these two local variables right before returning?

The two values will be emitted in the telemetry, within the finally block of the try-catch statement.

vicheey · 2025-02-20T23:54:57Z

packages/core/src/awsService/appBuilder/serverlessLand/main.ts

+    }).run()
+}
+
+async function downloadPatternCode(config: CreateServerlessLandWizardForm): Promise<void> {


If this is going to be used in other places as well, I suggest bringing these function outside of main.py and into another file in this folder for readability.

vicheey · 2025-02-21T00:03:00Z

packages/core/src/awsService/appBuilder/serverlessLand/wizard.ts

-            })
+        const iacOptions = this.metadataManager.getIacOptions(pattern)
+        if (iacOptions.length === 0) {
+            throw new Error('No IAC options found for the selected pattern')


Not a blocker but we should utilize localize() function instead of hard coding.Example:

localize('AWS.command.launchConfigForm.title', 'Local Invoke and Debug Configuration')

AWS.command.launchConfigForm.title

packages/core/src/awsService/appBuilder/serverlessLand/wizard.ts

Vandita2020 force-pushed the download_code branch 5 times, most recently from a20965f to 1e35324 Compare February 20, 2025 20:52

Vandita Patidar added 3 commits February 20, 2025 13:02

Building Quick Pick structure

3631142

Arranging file structure

2495b61

Review revision

8a9d285

Vandita2020 force-pushed the download_code branch from 1e35324 to e23a824 Compare February 20, 2025 21:42

Vandita2020 changed the title ~~Download code~~ feat(lambda): download serverless patterns in IDE Feb 20, 2025

Vandita2020 marked this pull request as ready for review February 20, 2025 21:43

Vandita2020 requested a review from a team as a code owner February 20, 2025 21:43

roger-zhangg suggested changes Feb 20, 2025

View reviewed changes

Vandita2020 changed the title ~~feat(lambda): download serverless patterns in IDE~~ feat(lambda): download serverless land patterns in IDE Feb 20, 2025

Download code

c8e7703

Vandita2020 force-pushed the download_code branch from e23a824 to c8e7703 Compare February 20, 2025 23:12

vicheey reviewed Feb 20, 2025

View reviewed changes

vicheey suggested changes Feb 21, 2025

View reviewed changes

Updating wizard file

c5104e2

Vandita2020 force-pushed the download_code branch from 3e3a123 to c5104e2 Compare February 21, 2025 05:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lambda): download serverless land patterns in IDE #6612

feat(lambda): download serverless land patterns in IDE #6612

Vandita2020 commented Feb 18, 2025 •

edited

Loading

github-actions bot commented Feb 18, 2025

roger-zhangg left a comment •

edited

Loading

roger-zhangg Feb 20, 2025

vicheey Feb 20, 2025

roger-zhangg Feb 20, 2025 •

edited

Loading

Vandita2020 Feb 21, 2025

github-actions bot commented Feb 20, 2025

vicheey Feb 20, 2025

Vandita2020 Feb 21, 2025

vicheey Feb 20, 2025

vicheey Feb 21, 2025

feat(lambda): download serverless land patterns in IDE #6612

Are you sure you want to change the base?

feat(lambda): download serverless land patterns in IDE #6612

Conversation

Vandita2020 commented Feb 18, 2025 • edited Loading

Problem

Solution

github-actions bot commented Feb 18, 2025

roger-zhangg left a comment • edited Loading

Choose a reason for hiding this comment

roger-zhangg Feb 20, 2025

Choose a reason for hiding this comment

vicheey Feb 20, 2025

Choose a reason for hiding this comment

roger-zhangg Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

Vandita2020 Feb 21, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 20, 2025

vicheey Feb 20, 2025

Choose a reason for hiding this comment

Vandita2020 Feb 21, 2025

Choose a reason for hiding this comment

vicheey Feb 20, 2025

Choose a reason for hiding this comment

vicheey Feb 21, 2025

Choose a reason for hiding this comment

Vandita2020 commented Feb 18, 2025 •

edited

Loading

roger-zhangg left a comment •

edited

Loading

roger-zhangg Feb 20, 2025 •

edited

Loading