Skip to content

Upgrad from UL20 to AL2023 DLAMIs in DLC testing infra #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
May 1, 2025

Conversation

zhuofuAMZ
Copy link
Contributor

GitHub Issue #, if available:

Note:

  • If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

  • All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.

Description

Tests run

NOTE: By default, docker builds are disabled. In order to build your container, please update dlc_developer_config.toml and specify the framework to build in "build_frameworks"

  • I have run builds/tests on commit for my changes.
Confused on how to run tests? Try using the helper utility...

Assuming your remote is called origin (you can find out more with git remote -v)...

  • Run default builds and tests for a particular buildspec - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp origin

  • Enable specific tests for a buildspec or set of buildspecs - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp origin

  • Restore TOML file when ready to merge

python src/prepare_dlc_dev_environment.py -rcp origin

NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:

Expand
  • sagemaker_remote_tests = true
  • sagemaker_efa_tests = true
  • sagemaker_rc_tests = true

Additionally, please run the sagemaker local tests in at least one revision:

  • sagemaker_local_tests = true

Formatting

DLC image/dockerfile

Builds to Execute

Expand

Fill out the template and click the checkbox of the builds you'd like to execute

Note: Replace with <X.Y> with the major.minor framework version (i.e. 2.2) you would like to start.

  • build_pytorch_training_<X.Y>_sm

  • build_pytorch_training_<X.Y>_ec2

  • build_pytorch_inference_<X.Y>_sm

  • build_pytorch_inference_<X.Y>_ec2

  • build_pytorch_inference_<X.Y>_graviton

  • build_tensorflow_training_<X.Y>_sm

  • build_tensorflow_training_<X.Y>_ec2

  • build_tensorflow_inference_<X.Y>_sm

  • build_tensorflow_inference_<X.Y>_ec2

  • build_tensorflow_inference_<X.Y>_graviton

Additional context

PR Checklist

Expand
  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron/graviton] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • If the PR changes affects SM test, I've modified dlc_developer_config.toml in my PR branch by setting sagemaker_tests = true and efa_tests = true
  • If this PR changes existing code, the change fully backward compatible with pre-existing code. (Non backward-compatible changes need special approval.)
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

NEURON/GRAVITON Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting neuron_mode = true or graviton_mode = true

Benchmark Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting ec2_benchmark_tests = true or sagemaker_benchmark_tests = true

Pytest Marker Checklist

Expand
  • (If applicable) I have added the marker @pytest.mark.model("<model-type>") to the new tests which I have added, to specify the Deep Learning model that is used in the test (use "N/A" if the test doesn't use a model)
  • (If applicable) I have added the marker @pytest.mark.integration("<feature-being-tested>") to the new tests which I have added, to specify the feature that will be tested
  • (If applicable) I have added the marker @pytest.mark.multinode(<integer-num-nodes>) to the new tests which I have added, to specify the number of nodes used on a multi-node test
  • (If applicable) I have added the marker @pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">) to the new tests which I have added, if a test is specifically applicable to only one processor type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhuofuAMZ zhuofuAMZ requested a review from a team as a code owner April 24, 2025 18:17
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added authorized Size:S Determines the size of the PR labels Apr 24, 2025
@zhuofuAMZ zhuofuAMZ force-pushed the al2023 branch 5 times, most recently from 2d94999 to ef643e8 Compare April 26, 2025 15:08
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added ec2 Reflects file change in dlc_tests/ec2 folder sanity Reflects file change in dlc_tests/sanity folder test Reflects file change in test folder labels Apr 26, 2025
@zhuofuAMZ
Copy link
Contributor Author

PT training and inference passed in [2c223c2](https://github.com/aws/deep-learning-containers/pull/4742/commits/2c223c2bd9f7712c4fdc24d7370a0121d9283f4c)

@zhuofuAMZ
Copy link
Contributor Author

Build SM image, only
dlc-pr-pytorch-inference_dlc-pr-sagemaker-local-test failed. other tests passed

@zhuofuAMZ
Copy link
Contributor Author

security.py shows dnf command not found, have to revert it back to apt-get

@zhuofuAMZ zhuofuAMZ requested review from a team as code owners April 28, 2025 21:37
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added the benchmark Reflects file change in dlc_tests/benchmark folder label Apr 28, 2025
@zhuofuAMZ
Copy link
Contributor Author

arm64 PT inference passed,
dlc-pr-pytorch-arm64-training failed as expected.

@zhuofuAMZ
Copy link
Contributor Author

graviton passed

@zhuofuAMZ
Copy link
Contributor Author

sagemaker local test passed.

@zhuofuAMZ
Copy link
Contributor Author

dlc-pr-pytorch-training_dlc-pr-sagemaker-local-testfailed with docker-compose not installed. But it seems that PT training does not container docker-compose. only TF training has that test

@zhuofuAMZ
Copy link
Contributor Author

sm local test passed

@zhuofuAMZ zhuofuAMZ merged commit 4765b5e into aws:master May 1, 2025
31 checks passed
@zhuofuAMZ zhuofuAMZ deleted the al2023 branch May 1, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authorized benchmark Reflects file change in dlc_tests/benchmark folder ec2 Reflects file change in dlc_tests/ec2 folder sagemaker_tests sanity Reflects file change in dlc_tests/sanity folder Size:S Determines the size of the PR test Reflects file change in test folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants