Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spurious newline in Prowjobs #430

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Remove spurious newline in Prowjobs #430

merged 1 commit into from
Oct 8, 2024

Conversation

abhay-krishna
Copy link
Member

A newline was added to all Prowjobs in #386 because of a trailing newline to the builder-base tag file. Removing that by trimming the image URI constructed in the Go template.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sp1999
Copy link
Member

sp1999 commented Oct 8, 2024

/lgtm

@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 18ba870 into aws:main Oct 8, 2024
2 checks passed
@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key autoscaler-1-27-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/autoscaler-1-27-presubmits.yaml
  • key autoscaler-1-28-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/autoscaler-1-28-presubmits.yaml
  • key autoscaler-1-29-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/autoscaler-1-29-presubmits.yaml
  • key autoscaler-1-30-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/autoscaler-1-30-presubmits.yaml
  • key autoscaler-1-31-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/autoscaler-1-31-presubmits.yaml
  • key aws-image-builder-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/aws-image-builder-presubmits.yaml
  • key aws-otel-collector-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/aws-otel-collector-presubmits.yaml
  • key boots-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/boots-presubmit.yaml
  • key bottlerocket-bootstrap-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/bottlerocket-bootstrap-presubmits.yaml
  • key cert-manager-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cert-manager-presubmits.yaml
  • key cilium-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cilium-presubmits.yaml
  • key cloud-provider-aws-1-27-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-aws-1-27-presubmit.yaml
  • key cloud-provider-aws-1-28-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-aws-1-28-presubmit.yaml
  • key cloud-provider-aws-1-29-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-aws-1-29-presubmit.yaml
  • key cloud-provider-aws-1-30-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-aws-1-30-presubmit.yaml
  • key cloud-provider-aws-1-31-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-aws-1-31-presubmit.yaml
  • key cloud-provider-nutanix-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-nutanix-presubmits.yaml
  • key cloud-provider-vsphere-1-27-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-vsphere-1-27-presubmits.yaml
  • key cloud-provider-vsphere-1-28-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-vsphere-1-28-presubmits.yaml
  • key cloud-provider-vsphere-1-29-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-vsphere-1-29-presubmits.yaml
  • key cloud-provider-vsphere-1-30-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-vsphere-1-30-presubmits.yaml
  • key cloud-provider-vsphere-1-31-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-vsphere-1-31-presubmits.yaml
  • key cloudstack-cloudmonkey-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cloudstack-cloudmonkey-presubmits.yaml
  • key cluster-api-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cluster-api-presubmits.yaml
  • key cluster-api-provider-aws-snow-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cluster-api-provider-aws-snow-presubmits.yaml
  • key cluster-api-provider-cloudstack-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cluster-api-provider-cloudstack-presubmits.yaml
  • key cluster-api-provider-nutanix-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cluster-api-provider-nutanix-presubmits.yaml
  • key cluster-api-provider-tinkerbell-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cluster-api-provider-tinkerbell-presubmits.yaml
  • key cluster-api-provider-vsphere-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cluster-api-provider-vsphere-presubmits.yaml
  • key containerd-presubmits-amd64.yaml using file jobs/aws/eks-anywhere-build-tooling/containerd-presubmits-amd64.yaml
  • key containerd-presubmits-arm64.yaml using file jobs/aws/eks-anywhere-build-tooling/containerd-presubmits-arm64.yaml
  • key cri-tools-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/cri-tools-presubmits.yaml
  • key dhcp-presubmits-amd64.yaml using file jobs/aws/eks-anywhere-build-tooling/dhcp-presubmits-amd64.yaml
  • key dhcp-presubmits-arm64.yaml using file jobs/aws/eks-anywhere-build-tooling/dhcp-presubmits-arm64.yaml
  • key distribution-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/distribution-presubmits.yaml
  • key eks-a-admin-image-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/eks-a-admin-image-presubmits.yaml
  • key eks-a-upgrader-image-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/eks-a-upgrader-image-presubmits.yaml
  • key eks-anywhere-attribution-periodics-release-0.20.yaml using file jobs/aws/eks-anywhere-build-tooling/eks-anywhere-attribution-periodics-release-0.20.yaml
  • key eks-anywhere-attribution-periodics.yaml using file jobs/aws/eks-anywhere-build-tooling/eks-anywhere-attribution-periodics.yaml
  • key eks-anywhere-cli-tools-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/eks-anywhere-cli-tools-presubmits.yaml
  • key eks-anywhere-diagnostic-collector-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/eks-anywhere-diagnostic-collector-presubmits.yaml
  • key eks-anywhere-packages-image-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/eks-anywhere-packages-image-presubmits.yaml
  • key emissary-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/emissary-presubmits.yaml
  • key envoy-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/envoy-presubmit.yaml
  • key etcdadm-bootstrap-provider-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/etcdadm-bootstrap-provider-presubmits.yaml
  • key etcdadm-controller-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/etcdadm-controller-presubmits.yaml
  • key etcdadm-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/etcdadm-presubmits.yaml
  • key flux-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/flux-presubmits.yaml
  • key govmomi-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/govmomi-presubmits.yaml
  • key harbor-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/harbor-presubmits.yaml
  • key harbor-scanner-trivy-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/harbor-scanner-trivy-presubmits.yaml
  • key hegel-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/hegel-presubmits.yaml
  • key hello-eks-anywhere-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/hello-eks-anywhere-presubmits.yaml
  • key helm-controller-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/helm-controller-presubmits.yaml
  • key helm-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/helm-presubmits.yaml
  • key hook-presubmit-amd64.yaml using file jobs/aws/eks-anywhere-build-tooling/hook-presubmit-amd64.yaml
  • key hook-presubmit-arm64.yaml using file jobs/aws/eks-anywhere-build-tooling/hook-presubmit-arm64.yaml
  • key hub-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/hub-presubmit.yaml
  • key imagebuilder-1-27-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/imagebuilder-1-27-presubmits.yaml
  • key imagebuilder-1-28-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/imagebuilder-1-28-presubmits.yaml
  • key imagebuilder-1-29-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/imagebuilder-1-29-presubmits.yaml
  • key imagebuilder-1-30-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/imagebuilder-1-30-presubmits.yaml
  • key imagebuilder-1-31-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/imagebuilder-1-31-presubmits.yaml
  • key ipxedust-presubmits-amd64.yaml using file jobs/aws/eks-anywhere-build-tooling/ipxedust-presubmits-amd64.yaml
  • key ipxedust-presubmits-arm64.yaml using file jobs/aws/eks-anywhere-build-tooling/ipxedust-presubmits-arm64.yaml
  • key kind-1-27-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/kind-1-27-presubmits.yaml
  • key kind-1-28-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/kind-1-28-presubmits.yaml
  • key kind-1-29-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/kind-1-29-presubmits.yaml
  • key kind-1-30-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/kind-1-30-presubmits.yaml
  • key kind-1-31-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/kind-1-31-presubmits.yaml
  • key kube-rbac-proxy-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/kube-rbac-proxy-presubmits.yaml
  • key kube-vip-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/kube-vip-presubmits.yaml
  • key kustomize-controller-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/kustomize-controller-presubmits.yaml
  • key linux-bootconfig-presubmits-amd64.yaml using file jobs/aws/eks-anywhere-build-tooling/linux-bootconfig-presubmits-amd64.yaml
  • key linux-bootconfig-presubmits-arm64.yaml using file jobs/aws/eks-anywhere-build-tooling/linux-bootconfig-presubmits-arm64.yaml
  • key linuxkit-presubmits-amd64.yaml using file jobs/aws/eks-anywhere-build-tooling/linuxkit-presubmits-amd64.yaml
  • key linuxkit-presubmits-arm64.yaml using file jobs/aws/eks-anywhere-build-tooling/linuxkit-presubmits-arm64.yaml
  • key local-path-provisioner-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/local-path-provisioner-presubmits.yaml
  • key metallb-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/metallb-presubmits.yaml
  • key metrics-server-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/metrics-server-presubmits.yaml
  • key notification-controller-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/notification-controller-presubmits.yaml
  • key prometheus-node-exporter-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/prometheus-node-exporter-presubmits.yaml
  • key prometheus-prometheus-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/prometheus-prometheus-presubmits.yaml
  • key redis-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/redis-presubmits.yaml
  • key rolesanywhere-credential-helper-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/rolesanywhere-credential-helper-presubmits.yaml
  • key rufio-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/rufio-presubmits.yaml
  • key runc-presubmits-amd64.yaml using file jobs/aws/eks-anywhere-build-tooling/runc-presubmits-amd64.yaml
  • key runc-presubmits-arm64.yaml using file jobs/aws/eks-anywhere-build-tooling/runc-presubmits-arm64.yaml
  • key source-controller-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/source-controller-presubmits.yaml
  • key tink-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/tink-presubmits.yaml
  • key tinkerbell-chart-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/tinkerbell-chart-presubmits.yaml
  • key tinkerbell-crds-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/tinkerbell-crds-presubmits.yaml
  • key tinkerbell-stack-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/tinkerbell-stack-presubmits.yaml
  • key trivy-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/trivy-presubmits.yaml
  • key troubleshoot-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/troubleshoot-presubmits.yaml
  • key validate-generated-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/validate-generated-presubmit.yaml
  • key eks-anywhere-packages-generatebundle-presubmits.yaml using file jobs/aws/eks-anywhere-packages/eks-anywhere-packages-generatebundle-presubmits.yaml
  • key eks-anywhere-packages-presubmits.yaml using file jobs/aws/eks-anywhere-packages/eks-anywhere-packages-presubmits.yaml
  • key eks-anywhere-prowjobs-lint-presubmits.yaml using file jobs/aws/eks-anywhere-prow-jobs/eks-anywhere-prowjobs-lint-presubmits.yaml
  • key cli-generate-golden-files-periodics.yaml using file jobs/aws/eks-anywhere/cli-generate-golden-files-periodics.yaml
  • key eks-anywhere-brew-update-postsubmits.yaml using file jobs/aws/eks-anywhere/eks-anywhere-brew-update-postsubmits.yaml
  • key eks-anywhere-cli-attribution-periodic.yaml using file jobs/aws/eks-anywhere/eks-anywhere-cli-attribution-periodic.yaml
  • key eks-anywhere-cli-attribution-presubmit.yaml using file jobs/aws/eks-anywhere/eks-anywhere-cli-attribution-presubmit.yaml
  • key eks-anywhere-cluster-controller-presubmits.yaml using file jobs/aws/eks-anywhere/eks-anywhere-cluster-controller-presubmits.yaml
  • key eks-anywhere-development-bundle-presubmit.yaml using file jobs/aws/eks-anywhere/eks-anywhere-development-bundle-presubmit.yaml
  • key eks-anywhere-development-eks-a-release-presubmit.yaml using file jobs/aws/eks-anywhere/eks-anywhere-development-eks-a-release-presubmit.yaml
  • key eks-anywhere-docs-presubmits.yaml using file jobs/aws/eks-anywhere/eks-anywhere-docs-presubmits.yaml
  • key eks-anywhere-e2e-cleanup-periodics.yaml using file jobs/aws/eks-anywhere/eks-anywhere-e2e-cleanup-periodics.yaml
  • key eks-anywhere-e2e-presubmits.yaml using file jobs/aws/eks-anywhere/eks-anywhere-e2e-presubmits.yaml
  • key eks-anywhere-e2e-validate-tinkerbell-hardware-presubmits.yaml using file jobs/aws/eks-anywhere/eks-anywhere-e2e-validate-tinkerbell-hardware-presubmits.yaml
  • key eks-anywhere-generate-files-presubmits.yaml using file jobs/aws/eks-anywhere/eks-anywhere-generate-files-presubmits.yaml
  • key eks-anywhere-presubmits.yaml using file jobs/aws/eks-anywhere/eks-anywhere-presubmits.yaml
  • key eks-anywhere-production-bundle-presubmit.yaml using file jobs/aws/eks-anywhere/eks-anywhere-production-bundle-presubmit.yaml
  • key eks-anywhere-production-eks-a-release-presubmit.yaml using file jobs/aws/eks-anywhere/eks-anywhere-production-eks-a-release-presubmit.yaml
  • key eks-anywhere-release-tooling-presubmits.yaml using file jobs/aws/eks-anywhere/eks-anywhere-release-tooling-presubmits.yaml
  • key eks-anywhere-release-tooling-test-presubmits.yaml using file jobs/aws/eks-anywhere/eks-anywhere-release-tooling-test-presubmits.yaml

In response to this:

A newline was added to all Prowjobs in #386 because of a trailing newline to the builder-base tag file. Removing that by trimming the image URI constructed in the Go template.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sp1999 sp1999

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhay-krishna @sp1999 @eks-distro-bot