Skip to content

feat: jsii and jsii-rosetta v5.9 #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2025
Merged

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Aug 6, 2025

This PR bumps jsii and jsii-rosetta dependencies from version 5.8.0 to 5.9.1 across multiple packages.

Changes

  • Updated jsii from 5.8.0 to 5.9.1
  • Updated jsii-rosetta from 5.8.0 to 5.9.1
  • Updated workflow configuration

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 6, 2025
@mrgrain mrgrain marked this pull request as draft August 6, 2025 15:24
@mrgrain mrgrain marked this pull request as ready for review August 7, 2025 09:32
@mrgrain mrgrain force-pushed the mrgrain/chore/version-bump-5.9.0 branch from 3fa7b19 to fff805c Compare August 7, 2025 09:32
@mrgrain mrgrain changed the title chore: bump jsii and jsii-rosetta to version 5.9.0 feat: jsii and jsii-rosetta v5.9 Aug 7, 2025
@mrgrain mrgrain force-pushed the mrgrain/chore/version-bump-5.9.0 branch from fff805c to e7dc419 Compare August 7, 2025 09:39
"pyright": "^1.1.403"
},
"peerDependencies": {
"jsii-rosetta": ">=5.5.0"
"jsii-rosetta": ">=5.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this peer dependency on jsii-rosetta lag behind?

Copy link
Contributor Author

@mrgrain mrgrain Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the lowest version that's still supported. I think it's just a bit random depending when we do the update.

@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Aug 8, 2025
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as i assume my comment will be addressed

@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Aug 8, 2025
Copy link
Contributor

mergify bot commented Aug 8, 2025

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Aug 8, 2025
Copy link
Contributor

mergify bot commented Aug 8, 2025

Merging (with squash)...

Copy link
Contributor

mergify bot commented Aug 8, 2025

Merging (with squash)...

@mergify mergify bot merged commit fd4385a into main Aug 8, 2025
28 checks passed
@mergify mergify bot deleted the mrgrain/chore/version-bump-5.9.0 branch August 8, 2025 19:54
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants