-
Notifications
You must be signed in to change notification settings - Fork 255
feat: jsii and jsii-rosetta v5.9 #4885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3fa7b19
to
fff805c
Compare
fff805c
to
e7dc419
Compare
"pyright": "^1.1.403" | ||
}, | ||
"peerDependencies": { | ||
"jsii-rosetta": ">=5.5.0" | ||
"jsii-rosetta": ">=5.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does this peer dependency on jsii-rosetta lag behind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the lowest version that's still supported. I think it's just a bit random depending when we do the update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving as i assume my comment will be addressed
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Merging (with squash)... |
This PR bumps jsii and jsii-rosetta dependencies from version 5.8.0 to 5.9.1 across multiple packages.
Changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.