revert: #719 #729
Merged
revert: #719 #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 90597c2.
…on windows and behind proxy
rli
approved these changes
Dec 19, 2025
aseemxs
approved these changes
Dec 19, 2025
shruti0085
approved these changes
Dec 19, 2025
Will-ShaoHua
pushed a commit
that referenced
this pull request
Dec 19, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>language-server-runtimes: 0.3.12</summary> ## [0.3.12](language-server-runtimes/v0.3.11...language-server-runtimes/v0.3.12) (2025-12-19) ### Reverts * pr 719 as dependency change cause unexpected network issue on windows machine ([#729](#729)) ([3987770](3987770)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pallymore
reviewed
Dec 24, 2025
| "vscode-uri": "^3.1.0", | ||
| "win-ca": "^3.5.1", | ||
| "winreg": "^1.2.5" | ||
| "registry-js": "^1.16.1" |
Member
There was a problem hiding this comment.
instead of re-introducing this dependency with known CVE - is there a better fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
aws/aws-toolkit-vscode#8454
aws/aws-toolkit-vscode#8453
aws/aws-toolkit-vscode#8451
aws/aws-toolkit-vscode#8448
aws/aws-toolkit-vscode#8445
aws/aws-toolkit-vscode#8444
aws/aws-toolkit-vscode#8442
aws/aws-toolkit-vscode#8440
Solution
Revert
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.