Skip to content

Conversation

@liramon1
Copy link

Problem

The agentic bundle for the CodeWhisperer LSP only supports SSO. If language clients want it to consume IAM credentials, they must start a completely separate bundle which includes the IAM implementation of the CodeWhisperer LSP. This prevents clients from seamlessly switching authentication methods at runtime.

Solution

This is part of #1936.

This PR combines the IAM and SSO implementations of the StreamingClientService, which is a prerequisite for combining the IAM and SSO implementations of AmazonQServiceManager. References to StreamingClientServiceToken and StreamingClientServiceIAM will be changed in a later PR.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@liramon1 liramon1 requested a review from a team as a code owner July 23, 2025 14:25
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 53.76884% with 184 lines in your changes missing coverage. Please review.

Project coverage is 65.86%. Comparing base (1491f4f) to head (447c8c0).

Files with missing lines Patch % Lines
...p-codewhisperer/src/shared/codeWhispererService.ts 37.07% 168 Missing ⚠️
...codewhisperer/src/shared/streamingClientService.ts 85.32% 16 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/flare-iam-base    #1959      +/-   ##
==========================================================
- Coverage                   65.96%   65.86%   -0.10%     
==========================================================
  Files                         238      238              
  Lines                       50623    50785     +162     
  Branches                     3385     3401      +16     
==========================================================
+ Hits                        33393    33452      +59     
- Misses                      17170    17273     +103     
  Partials                       60       60              
Flag Coverage Δ
unittests 65.86% <53.76%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liramon1 liramon1 changed the base branch from feature/flare-iam-base to liramon/flare-iam-base July 24, 2025 22:46
@liramon1 liramon1 closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants