Skip to content

Conversation

@liramon1
Copy link

Problem

The agentic bundle for the CodeWhisperer LSP only supports SSO. If language clients want it to consume IAM credentials, they must start a completely separate bundle which includes the IAM implementation of the CodeWhisperer LSP. This prevents clients from seamlessly switching authentication methods at runtime.

Solution

This is part of #1936.

This PR changes references from the IAM/SSO implementations of CodeWhispererService, StreamingClientService, and AmazonQServiceManager to the unified implementations from the prior PRs.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@liramon1 liramon1 requested a review from a team as a code owner July 23, 2025 14:43
@liramon1 liramon1 changed the title Unified cw4 refactor(amazonq): change IAM and SSO service references Jul 23, 2025
@liramon1 liramon1 changed the title refactor(amazonq): change IAM and SSO service references refactor(amazonq): change IAM and SSO service references to unified service references Jul 23, 2025
@liramon1 liramon1 changed the title refactor(amazonq): change IAM and SSO service references to unified service references refactor(amazonq): change IAM and SSO service references Jul 23, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.00746% with 209 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/flare-iam-base@1491f4f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...p-codewhisperer/src/shared/codeWhispererService.ts 36.12% 168 Missing ⚠️
...codewhisperer/src/shared/streamingClientService.ts 84.90% 16 Missing ⚠️
...rer/src/language-server/chat/chatSessionService.ts 50.00% 4 Missing ⚠️
...er/securityScan/codeWhispererSecurityScanServer.ts 0.00% 4 Missing ⚠️
...r/aws-lsp-codewhisperer/src/shared/proxy-server.ts 0.00% 4 Missing ⚠️
...nguage-server/agenticChat/agenticChatController.ts 72.72% 3 Missing ⚠️
...r/localProjectContext/localProjectContextServer.ts 0.00% 3 Missing ⚠️
...language-server/netTransform/netTransformServer.ts 0.00% 3 Missing ⚠️
...rc/language-server/agenticChat/tools/toolServer.ts 0.00% 2 Missing ⚠️
...ge-server/inline-completion/codeWhispererServer.ts 90.90% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                    Coverage Diff                    @@
##             feature/flare-iam-base    #1961   +/-   ##
=========================================================
  Coverage                          ?   65.82%           
=========================================================
  Files                             ?      237           
  Lines                             ?    50675           
  Branches                          ?     3400           
=========================================================
  Hits                              ?    33357           
  Misses                            ?    17258           
  Partials                          ?       60           
Flag Coverage Δ
unittests 65.82% <61.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liramon1 liramon1 changed the base branch from feature/flare-iam-base to liramon/flare-iam-base July 24, 2025 22:45
@liramon1 liramon1 marked this pull request as draft July 25, 2025 14:53
@liramon1 liramon1 closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants