Skip to content

Conversation

@liramon1
Copy link

@liramon1 liramon1 commented Jul 24, 2025

Problem

The CodeWhispererService base, IAM, and token variants are all in the same file. This makes it cumbersome to extend as more features are added.

Solution

This is part of #1981.

Split the CodeWhispererService class into their own files and update the import paths for them.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@liramon1 liramon1 requested a review from a team as a code owner July 24, 2025 18:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 54.15020% with 1160 lines in your changes missing coverage. Please review.

Project coverage is 61.15%. Comparing base (1491f4f) to head (d41f3a3).

Files with missing lines Patch % Lines
.../language-server/agenticChat/tools/mcp/mcpUtils.ts 39.81% 328 Missing ⚠️
...anguage-server/agenticChat/tools/mcp/mcpManager.ts 62.84% 149 Missing ⚠️
...ge-server/agenticChat/tools/mcp/mcpEventHandler.ts 18.46% 106 Missing ⚠️
chat-client/src/client/mynahUi.ts 30.15% 86 Missing and 2 partials ⚠️
.../language-server/agenticChat/tools/mcp/mcpTypes.ts 22.50% 62 Missing ⚠️
...orkspaceContext/dependency/dependencyDiscoverer.ts 2.43% 40 Missing ⚠️
server/aws-lsp-codewhisperer/src/shared/utils.ts 9.09% 40 Missing ⚠️
...anguage-server/workspaceContext/artifactManager.ts 11.62% 38 Missing ⚠️
...nguage-server/agenticChat/agenticChatController.ts 71.05% 33 Missing ⚠️
...rver/agenticChat/tools/qCodeAnalysis/codeReview.ts 86.32% 29 Missing ⚠️
... and 24 more
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/flare-iam-base    #1974      +/-   ##
==========================================================
- Coverage                   65.96%   61.15%   -4.82%     
==========================================================
  Files                         238      240       +2     
  Lines                       50623    52029    +1406     
  Branches                     3385     3104     -281     
==========================================================
- Hits                        33393    31816    -1577     
- Misses                      17170    20157    +2987     
+ Partials                       60       56       -4     
Flag Coverage Δ
unittests 61.15% <54.15%> (-4.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liramon1 liramon1 changed the base branch from feature/flare-iam-base to liramon/flare-iam-base July 24, 2025 22:45
@liramon1 liramon1 force-pushed the split-codewhisperer branch from d41f3a3 to 4433f47 Compare July 24, 2025 23:11
@liramon1 liramon1 force-pushed the split-codewhisperer branch from 4433f47 to e916252 Compare July 25, 2025 02:17
@liramon1 liramon1 merged commit 92bb89b into aws:liramon/flare-iam-base Jul 25, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Jul 25, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Jul 25, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Jul 28, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Jul 29, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Jul 29, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Jul 30, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Jul 30, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Jul 30, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Jul 31, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Jul 31, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Aug 1, 2025
liramon1 added a commit to liramon1/language-servers that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants