refactor(amazonq): combine IAM and SSO implementations of AmazonQServiceManager #1984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liramon1
force-pushed
the
liramon/flare-iam-base
branch
4 times, most recently
from
4f5fc2d to
d093e42
Compare
liramon1
force-pushed
the
liramon/flare-iam-base
branch
3 times, most recently
from
82eeaf9 to
e96e1c1
Compare
liramon1
force-pushed
the
unified-cw2
branch
2 times, most recently
from
0b44a44 to
ae8d6d7
Compare
leigaol
reviewed
Jul 29, 2025
|
|
||
| private streamingClientFactory(region: string, endpoint: string): StreamingClientServiceBase { | ||
| let streamingClient: StreamingClientServiceBase | ||
| if (this.features.credentialsProvider.hasCredentials('iam')) { |
Contributor
There was a problem hiding this comment.
this should also apply to non streaming client
liramon1
force-pushed
the
liramon/flare-iam-base
branch
from
d06f3bd to
4ffa4fe
Compare
liramon1
force-pushed
the
liramon/flare-iam-base
branch
from
4ffa4fe to
2e54a43
Compare
liramon1
force-pushed
the
liramon/flare-iam-base
branch
from
2e54a43 to
e9050ee
Compare
liramon1
force-pushed
the
unified-cw2
branch
2 times, most recently
from
117a27c to
ad37057
Compare
liramon1
force-pushed
the
liramon/flare-iam-base
branch
from
776a609 to
8f1c33a
Compare
liramon1
force-pushed
the
liramon/flare-iam-base
branch
from
24d84ef to
b62b302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The agentic bundle for the CodeWhisperer LSP only supports SSO. If language clients want it to consume IAM credentials, they must start a completely separate bundle which includes the IAM implementation of the CodeWhisperer LSP. This prevents clients from seamlessly switching authentication methods at runtime.
Solution
This is part of #1981.
This PR combines the IAM and SSO implementations of the AmazonQServiceManager. References to AmazonQTokenServiceManager and AmazonQIAMServiceManager will be changed in a later PR.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.