feat: add telemetry to IAM credentials management #2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liramon1
changed the title
liramon1
force-pushed
the
liramon/flare-iam-base
branch
from
24d84ef to
b62b302
Compare
awschristou
approved these changes
Aug 1, 2025
Contributor
awschristou
left a comment
awschristou
left a comment
There was a problem hiding this comment.
You may want to validate in tests that iamProvider is making the new emitMetric calls. You'd want to validate the different credentialType values being passed in.
This is a preference, but I'm approving the PR in case that isn't feasible
awschristou
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The IAM credentials endpoint inside the identity LSP does not emit granular telemetry. This makes it difficult to track the popularity of each IAM retrieval method.
Solution
This is part of #1981.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.