chore: basic example how to use openTab on client/server side #865
+81
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmile
reviewed
Mar 25, 2025
| @@ -52,6 +64,35 @@ export function registerChat(languageClient: LanguageClient, extensionUri: Uri, | |||
| languageClient.info(`[VSCode Client] Received telemetry event from server ${JSON.stringify(e)}`) | |||
| }) | |||
|
|
|||
| languageClient.onRequest(openTabRequestType.method, async (params, _) => { | |||
| const mapErrorType = (type: string | undefined): number => { | |||
There was a problem hiding this comment.
Is it necessary to re-create this function every request?
There was a problem hiding this comment.
its only an example change so that I can start working on the open tab story
kmile
reviewed
Mar 25, 2025
| const endTime = Date.now() + 60000 // 1 minute from now | ||
| const sleep = (ms: number) => new Promise(resolve => setTimeout(resolve, ms)) | ||
| while (Date.now() < endTime) { | ||
| if (openTabResponseQueue.length > 0) { |
There was a problem hiding this comment.
Are tab requests and responses guaranteed to be in order? Can we index them by requestId instead?
kmile
reviewed
Mar 25, 2025
| @@ -132,12 +173,30 @@ export function registerChat(languageClient: LanguageClient, extensionUri: Uri, | |||
| if (!isValidAuthFollowUpType(message.params.followUp.type)) | |||
| languageClient.sendNotification(followUpClickNotificationType, message.params) | |||
| break | |||
| case openTabRequestType.method: | |||
| openTabResponseQueue.push(message.params) | |||
There was a problem hiding this comment.
Can we resolve the promise here immediately instead of spinning a loop every 100ms?
kmile
reviewed
Mar 25, 2025
| default: | ||
| if (isServerEvent(message.command)) languageClient.sendNotification(message.command, message.params) | ||
| break | ||
| } | ||
| }, undefined) | ||
|
|
||
| async function waitForOpenTabResult(): Promise<UiMessageResultParams | undefined> { | ||
| const endTime = Date.now() + 60000 // 1 minute from now |
There was a problem hiding this comment.
Why one minute? How expensive is it to create a tab?
kmile
reviewed
Mar 25, 2025
| @@ -105,6 +105,17 @@ export const QChatServer = | |||
| return chatController.onCodeInsertToCursorPosition(params) | |||
| }) | |||
|
|
|||
| chat.onReady(_ => { | |||
There was a problem hiding this comment.
Is this the expected behavior? To create a new tab on load?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DO NOT MERGE
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.