Skip to content

chore: update toolkit extension version for Sagemaker CodeEditor which has fix for compute region issue #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025

Conversation

parameja1
Copy link
Contributor

@parameja1 parameja1 commented Jul 16, 2025

Description

[Provide a brief description of the changes]

  • Update Toolkit version being used in v2 and v3 SMD versions to use 3.69 which is needed for CodeEditor spaces in Sagemaker Unified Studio and Sagemaker AI
  • The 3.69 version contains the fix for compute region issue which was observed with earlier Toolkit versions that prevented Toolkit extension installation in Sagemaker compute instances (SMAI and SMUS), hence need the change

Type of Change

  • Image update - Bug fix
  • Image update - New feature
  • Image update - Breaking change
  • SMD image build tool update
  • Documentation update

Release Information

Does this change need to be included in patch version releases? By default, any pull requests will only be added to the next SMD image minor version release once they are merged in template folder. Only critical bug fix or security update should be applied to new patch versions of existed image minor versions.

  • Yes (Critical bug fix or security update)
  • No (New feature or non-critical change)
  • N/A (Not an image update)

If yes, please explain why:
[Explain the criticality of this change and why it should be included in patch releases]

How Has This Been Tested?

  • Tested with the release artefact of Toolkit version 3.69 in SMUS CE space
  • Also tested in SMAI space and verified toolkit is working as expected

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Test Screenshots (if applicable):

  • image

Related Issues

Additional Notes

[Any additional information that might be helpful for reviewers]

…h has fix for

compute region issue

**Description**

**Testing Done**
@parameja1 parameja1 requested a review from a team as a code owner July 16, 2025 23:19
TRNWWZ
TRNWWZ previously approved these changes Jul 17, 2025
@@ -1,4 +1,4 @@
https://open-vsx.org/api/ms-toolsai/jupyter/2024.5.0/file/ms-toolsai.jupyter-2024.5.0.vsix
https://open-vsx.org/api/ms-python/python/2023.20.0/file/ms-python.python-2023.20.0.vsix
https://open-vsx.org/api/amazonwebservices/aws-toolkit-vscode/3.30.0/file/amazonwebservices.aws-toolkit-vscode-3.30.0.vsix
https://open-vsx.org/api/amazonwebservices/aws-toolkit-vscode/3.30.0/file/amazonwebservices.aws-toolkit-vscode-3.69.0.vsix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ws-toolkit-vscode/3.30.0/file

Does the 3.3.0 in this need to be 3.69? Or was the last version match a coincidence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, good catch, let me update back. Thanks Will

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated version path, verified vsix artefact is downloadable with the correct path now

@TRNWWZ TRNWWZ merged commit 2f32588 into aws:main Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants