Skip to content

Py312 upgrade step 2: Update dependencies, integ tests and unit tests #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 19, 2025

Conversation

mollyheamazon
Copy link
Contributor

author Molly He [email protected] 1740529460 -0800 committer Molly He [email protected] 1744156034 -0700

parent fb22b91
author Molly He [email protected] 1740529460 -0800 committer Molly He [email protected] 1744155953 -0700

parent fb22b91
author Molly He [email protected] 1740529460 -0800 committer Molly He [email protected] 1744155703 -0700

parent fb22b91
author Molly He [email protected] 1740529460 -0800 committer Molly He [email protected] 1744155683 -0700

Test py312 ci support

Test py312 ci support

first commit

test to point to personal stack

changed tox.ini

Revert "changed tox.ini"

This reverts commit 696cb47.

Revert "Revert "changed tox.ini""

This reverts commit 5d35bd0.

Revert "Revert "Revert "changed tox.ini"""

This reverts commit 2ab95fb.

Revert "Revert "changed tox.ini""

This reverts commit 5d35bd0.

Revert "changed tox.ini"

This reverts commit 696cb47.

Revert "test to point to personal stack"

This reverts commit 49de844.

Revert "first commit"

This reverts commit 1374184.

add pyproject.toml

add py312 to ci

bump numpy version

numpy version change

add py312

upgrade pip version

add setuptools wheel to tox.ini

add pyyaml version constraint, remove py312 from docstring because there is no py312 image yet

update pyyaml version constraint

update pyyaml version constraint

deprecate py38

bump scipy

bump tensorflow and tensorboard

bump dill

bump apache-airflow to ensure dill and greenlet version

remove constraint for apache-airflow

remove constraint for apache-airflow

bump torch version

bump torchvision version

new tests

try changing some tests

update model trainer test

fix test_pipeline

add constraint to apache in tox

Fix key error in _send_metrics() (#5068)

Co-authored-by: pintaoz [email protected]

Use sagemaker session's s3_resource in download_folder (#5064)

Co-authored-by: pintaoz [email protected]

Fix error when there is no session to call _create_model_request() (#5062)

  • Fix error when there is no session to call _create_model_request()

  • Fix codestyle


Co-authored-by: pintaoz [email protected]

Ensure Model.is_repack() returns a boolean (#5060)

  • Ensure Model.is_repack() returns a boolean

  • update test


Co-authored-by: pintaoz [email protected]

feat: Make DistributedConfig Extensible (#5039)

  • feat: Make DistributedConfig Extensible

  • pylint

  • Include none types when creating config jsons for safer reference

  • fix: update test to account for changes

  • format

  • Add integ test

  • pylint

  • prepare release v2.240.0

  • update development version to v2.240.1.dev0

  • Fix key error in _send_metrics() (Fix key error in _send_metrics() #5068)

Co-authored-by: pintaoz [email protected]

Co-authored-by: Keshav Chandak [email protected]

Co-authored-by: pintaoz [email protected]

  • remove union

  • fix merge artifact

  • Change dir path to distributed_drivers

  • update paths


Co-authored-by: ci
Co-authored-by: pintaoz-aws [email protected]
Co-authored-by: pintaoz [email protected]
Co-authored-by: Keshav Chandak [email protected]
Co-authored-by: Keshav Chandak [email protected]

Skip tests with deprecated instance type (#5077)

Co-authored-by: pintaoz [email protected]

pipeline definition function doc update (#5074)

Co-authored-by: Rohan Gujarathi [email protected]

feat: add integ tests for training JumpStart models in private hub (#5076)

  • feat: add integ tests for training JumpStart models in private hub

  • fixed formatting

  • remove unused imports

  • fix unused imports

  • fix unit test failure and fix bug around versioning

  • fix formatting

  • fix unit tests

  • fix model_uri usage issue

  • fix some formatting

  • separate private hub setup code

  • add try catch block

  • fix flake8 issue so except clause is not bare

  • black formatting

fix: resolve infinite loop in _find_config on Windows systems (#4970)

  • fix: resolve Windows path handling in _find_config

  • Replace Path.match("/") with Path.anchor comparison

  • Fix infinite loop in _studio.py path traversal

  • test: Add tests for the new root path exploration

  • Fix formatting style

  • Fixed line to long

  • Fix docstyle by running black manually

  • Fix testcase with \ when running on non-windows machines

  • Fix formatting style

  • cleanup unused import

change: update image_uri_configs 03-11-2025 07:18:09 PST

Fixing Pytorch training python version in tests (#5084)

  • Fixing Pytorch training python version in tests

  • Updating Inference test handling

remove s3 output location requirement from hub class init (#5081)

  • remove s3 output location requirement from hub class init

  • fix integ test hub

  • lint

  • fix test


Co-authored-by: Gokul Anantha Narayanan [email protected]

fix: Prevent RunContext overlap between test_run tests (#5083)

Co-authored-by: Gokul Anantha Narayanan [email protected]

remove py38 from unit testing

fix integ test by bumping py38 to py39 for PyTorch

change framework_version that supports py39 in integ tests

remove py38 from unit testing

Update estimator.py

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mollyheamazon mollyheamazon requested a review from a team as a code owner April 9, 2025 02:03
@mollyheamazon mollyheamazon requested a review from nargokul April 9, 2025 02:03
@benieric
Copy link
Contributor

Can we update branch to rebase with master

@mollyheamazon mollyheamazon force-pushed the origin/master-ci-py312-squash branch from 0356caf to 00741ed Compare April 18, 2025 19:58
benieric
benieric previously approved these changes Apr 18, 2025
Copy link
Contributor

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoqizqwang zhaoqizqwang merged commit 2d095ed into aws:master Apr 19, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants