-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Isort Checks for CI #5219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Isort Checks for CI #5219
Conversation
Could anyone please review this PR? cc: @mollyheamazon |
Could you please review? cc: @sage-maker |
Can you provide a justification for this change? |
As described in this issue, I have add isort checks to tox.
Could you please review? cc: @sage-maker |
Please fix |
I have add the missing cc: @sage-maker |
You will still fail the CodeQL checks, please fix thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CodeQL
Issue #1984
Description of changes: Added Isort for CI.
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.