Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ re-concatenate UserAgents that get split up #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

acidjazz
Copy link

@acidjazz acidjazz commented Oct 12, 2022

This is a fix for #150 - I'm sure it would be better to fix where it splits at the comma in the 1st place, but this at least helps identify the problem

When going from CloudFront -> Api Gateway -> Lambda my user agent looks like this:

like Gecko) Chrome/105.0.0.0 Safari/537.36,

While locally I get the full string:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36

@drakejin
Copy link
Contributor

drakejin commented May 25, 2023

I think You didn't get the point.

because, fiber or lambda adapter cannot split User Agents by character ','. You should check again your code.

If you want to prove your statements. Make a test code and show me. :) have a nice bro.

below picture is my local machine results.

Screen Shot 2023-05-26 at 12 35 54 AM

Copy link
Contributor

@drakejin drakejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a test code and prove it

@acidjazz
Copy link
Author

Make a test code and prove it

I specified this happens when going from CloudFront -> Api Gateway -> Lambda

This is not reproducible locally, and most definitely should work on this setup. I use my fork for my projects and it only works using it.

More importantly we have the bigger issue #175

@drakejin
Copy link
Contributor

drakejin commented May 26, 2023

Don't solve it in a macro way. Would you please check root causes? You just show me the result. It's just output not causes. I hope you to give me some test code or reproducible ways. May the problem is not by this module.

It's hard to prove your statement by myself. If the problem had occurred by many people, I will check immediately. but, not this time.

So, would you reproduce the issue and tell my how can I check the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants