Skip to content

reconnect to socket once online #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

reconnect to socket once online #606

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d171f18
reconnect to socket once online
jwelmac Dec 8, 2020
19fbe4d
ensure single reject on socket close
jwelmac Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/aws-appsync-subscription-link/src/realtime-subscription-handshake-link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,16 @@ export class AppSyncRealTimeSubscriptionHandshakeLink extends ApolloLink {
};
this.awsRealTimeSocket.onclose = event => {
logger(`WebSocket closed ${event.reason}`);
rej(new Error(JSON.stringify(event)));
// Error code 1000 means that the connection was closed normally.
if (event.code === 1000 || navigator.onLine) {
rej(new Error(JSON.stringify(event)));
} else {
logger("You are offline. Reconnecting once online");
// Initialize handshake once online again
window.addEventListener('online', () => {
this._initializeHandshake({ awsRealTimeUrl });
});
}
};

this.awsRealTimeSocket.onmessage = (message: MessageEvent) => {
Expand Down