Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sagemaker-helper): add comment to notebook function #1262

Merged
merged 2 commits into from
Feb 12, 2025
Merged

chore(sagemaker-helper): add comment to notebook function #1262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8336cfb
Add comment to Notebook function
biffgaut Feb 12, 2025
75adc41
lint
biffgaut Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions source/patterns/@aws-solutions-constructs/core/lib/sagemaker-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,11 @@ export interface BuildSagemakerNotebookResponse {

/**
* @internal This is an internal core function and should not be called directly by Solutions Constructs clients.
*
* The constructs deploying Sagemaker services only deploy Sagemaker Endpoints, Endpoint
* Configurations and (already developed) Models. There are no Constructs that deploy Notebooks.
* There doesn't appear to be any references to this function outside the unit test file - so
* this function is unneccessary.
*/
export function buildSagemakerNotebook(
scope: Construct,
Expand Down