Use multiple threads to load textures asynchronously. #2913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
TextureCacheto use multiple threads to handle the work ofAddImageAsync. The number of threads is set bystd::thread::hardware_concurrency().TextureCachenow usesstd::unique_ptrto make clear the ownership of data structures related to asynchronous texture loading. Redundant field_asyncRefCounthas been removed. Uses ofstd::dequehas been replaced by the more straightforwardstd::vector.I've tested this in my app on my phone as well as, with ThreadSanitizer enabled, on my laptop.