Feat: minor docs improvements for RLHF and faq on embeddings #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
reviewed
Mar 11, 2025
| rl: | ||
| # whether to perform weighting if doing DPO training. Boolean. | ||
| dpo_use_weighting: | ||
| rl_beta: # Optional[float]. The beta parameter for the RL training. |
There was a problem hiding this comment.
I think the recommended way is to use trl.beta now?
There was a problem hiding this comment.
Is that the recommended approach now? I was under the impression we're leaving the trl: namespace for GRPO specifically.
There was a problem hiding this comment.
From internal discussion, we will be keeping both for now and ensuring they are the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added following new questions on discord.
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)