-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use aarch64 runner for Flatpak #1149
Conversation
f6405b8
to
9a542e7
Compare
0ae2efb
to
61a4328
Compare
@barthalion Do you have an idea why the arm64 build fails with |
This would typically mean something is trying to hardlink across devices. Not sure how much sense this makes in the context of GitHub Actions. |
Anyway, it seems to have failed with some segfault, probably unrelated to that message. |
The arm64 build now seems to work with the image from |
.github/workflows/build.yaml
Outdated
# BUG https://github.com/flatpak/flatpak-github-actions/pull/179 | ||
# image: bilelmoussaoui/flatpak-github-actions:gnome-45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the image from flatpak
instead of flathub-infra
as it is more general and smaller and we are also using the action from that repository but the maintainer is not very responsive at the moment. So I suggest keeping the comment for future reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~ ❱ docker images | grep gnome-45
ghcr.io/flathub-infra/flatpak-github-actions gnome-45 0cd259c4f7c9 26 hours ago 5.45GB
bilelmoussaoui/flatpak-github-actions gnome-45 e84de63f2fa2 4 days ago 7.55GB
It's actually bigger by 2 GB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I thought it was the other way round as this was based on the small fedora
image. But it looks like it has a lot of inefficiencies like installing Flatpak builder twice (dnf
and flatpak
) for example.
@barthalion Which GitHub actions and Docker images do you recommend people to use? It is a little bit confusing with the many GitHub organizations and forks...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image and action from the flathub-infra org is the one we as in Flathub going to be recommending for the foreseable future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barthalion thanks. Are you just using @master
for the version of the GitHub Action? Or pin a commit SHA and update with dependabot?
8c485bd
to
65df253
Compare
65df253
to
34cfe05
Compare
This brings down the arm64 Flatpak build time from ~180min to ~20min.