Skip to content

Docs/more badges #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Docs/more badges #678

merged 2 commits into from
Dec 16, 2024

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Dec 16, 2024

Simple:

  • Add a badge for cargo-make to the build section.
  • Add a badge and link for the axone-objectarium, axone-cognitarium, axone-law-stone and axone-dataverse crates (thanks to Ci/publish #672).

Summary by CodeRabbit

  • Documentation
    • Enhanced README.md with a new badge indicating the use of cargo-make.
    • Added links to respective crates on crates.io for axone-objectarium, axone-cognitarium, axone-law-stone, and axone-dataverse contracts.
    • Reformatted status and version badges for consistency across documentation.
    • Maintained existing descriptions and structure while improving clarity and accessibility.

@ccamel ccamel self-assigned this Dec 16, 2024
Copy link

coderabbitai bot commented Dec 16, 2024

Walkthrough

The pull request introduces documentation enhancements to the README.md file for Axone Smart Contracts. The primary modifications include adding a new cargo-make badge, incorporating direct links to crate versions on crates.io for various contracts (objectarium, cognitarium, law-stone, and dataverse), and reformatting status badges for visual consistency. The core content and structure of the documentation remain unchanged, focusing on improving visibility and accessibility of contract information.

Changes

File Change Summary
README.md - Added cargo-make build badge
- Inserted direct links to crates.io for contract badges
- Reformatted status badges for uniformity

Suggested Reviewers

  • amimart
  • bdeneux

Possibly related PRs

Poem

🐰 Badges shine like carrots bright,
Cargo-make builds with pure delight!
Links to crates, a rabbit's glee,
Documentation's harmony
Hopping through code with playful might! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a99ce7 and 2bdc24e.

📒 Files selected for processing (1)
  • README.md (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
README.md (1)

41-41: Remove trailing spaces in badge image tags

There are trailing spaces after the badge image tags on lines 41, 77, 115, and 155. While they don't affect rendering, they should be removed for cleaner markdown.

-        <img alt="crates" src="https://img.shields.io/crates/v/axone-objectarium.svg?style=for-the-badge&color=orange"/> 
+        <img alt="crates" src="https://img.shields.io/crates/v/axone-objectarium.svg?style=for-the-badge&color=orange"/>

Also applies to: 77-77, 115-115, 155-155

🧰 Tools
🪛 Markdownlint (0.37.0)

41-41: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43b2c16 and 7a99ce7.

📒 Files selected for processing (1)
  • README.md (5 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
README.md

41-41: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


77-77: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


115-115: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


155-155: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

🔇 Additional comments (3)
README.md (3)

9-10: LGTM: Appropriate addition of cargo-make badge

The new badge aligns well with the build tools section and provides a helpful link to the cargo-make documentation.


35-42: LGTM: Consistent badge and link additions across contracts

The changes systematically add crates.io links and badges for all contracts while maintaining visual consistency. This enhancement improves the documentation by providing direct access to package information.

Also applies to: 71-78, 109-116, 149-156

🧰 Tools
🪛 Markdownlint (0.37.0)

41-41: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


41-41: Verify crate version badges are up-to-date

Let's ensure the version badges reflect the latest published versions on crates.io.

Also applies to: 77-77, 115-115, 155-155

✅ Verification successful

Let me check the actual badge versions in the README to compare with the crates.io versions.


Version badges are dynamically updated and accurate

The version badges in the README are using dynamic shields.io URLs that automatically fetch and display the latest versions from crates.io. All four crates (axone-objectarium, axone-cognitarium, axone-law-stone, and axone-dataverse) are correctly configured to show their current versions (7.0.0) without hardcoding the version numbers in the URLs.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the crate versions in badges match the latest published versions

echo "Checking latest versions for axone crates..."
for crate in axone-objectarium axone-cognitarium axone-law-stone axone-dataverse; do
  echo "Checking $crate..."
  curl -s "https://crates.io/api/v1/crates/$crate" | jq -r '.crate.max_version'
done

Length of output: 1066


Script:

#!/bin/bash
# Get the badge URLs from README.md to extract versions
cat README.md | grep -E "img.shields.io/crates/v/axone-.*\.svg"

Length of output: 549

🧰 Tools
🪛 Markdownlint (0.37.0)

41-41: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

@bot-anik
Copy link
Member

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/axone_objectarium.wasm 458.07 KB (0%)
target/wasm32-unknown-unknown/release/axone_law_stone.wasm 593.03 KB (0%)
target/wasm32-unknown-unknown/release/axone_cognitarium.wasm 882.05 KB (0%)
target/wasm32-unknown-unknown/release/axone_dataverse.wasm 697.14 KB (0%)

@ccamel ccamel merged commit 5cefed9 into main Dec 16, 2024
17 checks passed
@ccamel ccamel deleted the docs/more-badges branch December 16, 2024 17:57
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants